Github Badges via Discourse ID?

[dsims (Daniel)]

I assume meta is using the Github Plugin for Contributor badges. I just connected github to my Discourse ID, but would this even work with Discourse ID?

@simon

Users are found based on the email address of the Github commit. For most cases, this will be the user’s email address. For users who have configured git to use the Github no-reply email address (<username>@users.noreply.github.com), the plugin attempts to find the user based on the username part of that email address. It does this by searching the Discourse GithubUserInfo table for a username match. Users will only be found in this way if they have previously logged into Discourse via Github.

[mcwumbly (Dave McClure)]

@zogstrip maybe something for you to comment on, noodle on, given your recent tinkering with both Discourse ID and GitHub stuff.

I’m skimming the plugin docs and the specs here and it isn’t clear to me how we associate users in Discourse to users in GitHub. Do they need to have their user account on Discourse linked directly to GitHub? Or is it based on email address? (Or something else)?

[Falco]

Given that the primary method is email match, it will work just fine.

Contributors using different emails on GitHub than here can reach out to us and ask for manual badge assignments.

[mcwumbly (Dave McClure)]

@Falco

Given that the primary method is email match, it will work just fine.

Ah, cool. That’s the part I wasn’t clear about. Thanks for clarifying.

If I understand correctly now, directly associated accounts are only needed to automatically credit users that are using a different (or private) email address for commits.

[pmusaraj (Penar Musaraj)]

Falco is right, this should work. Note though that the only repository configured to grant Github badges here on meta is the main app repo (discourse/discourse). And, as Falco explained, the email address between your account here and your Github account need to match. (For example, I don’t have the badge because my email on my account here is different from my email for the Github account.)