GitHub diff stat link for commits results in 404 link

rugk · October 15, 2019, 9:52pm

Here is a box:

https://github.com/rugk/mastodon-simplified-federation/commit/f8dedaa250ce2ea1734731a107cbe25b24f660e9

STR

Click on the diff summary (+6-7 in this case) here…

What happens

404 error at https://github.com/rugk/mastodon-simplified-federation/commit/f8dedaa250ce2ea1734731a107cbe25b24f660e9/files

What should happen

Dunno. This is no PR, maybe this was made for PRs, where that link would make sense, but I don’t know where this should link to in case of commits…

The only thing I could imagine would be a direct link to the diff stat/summary on GitHub (if possible), i.e.:

Other

Possibly introduced by:

sam · October 15, 2019, 10:06pm

@david maybe you can have a look at this?

tshenry · October 15, 2019, 10:07pm

I think we might need to drop the /files from here, or pick a different location:

github.com/discourse/onebox

templates/githubcommit.mustache

main


      
          
                <div class="user">
                  <a href="{{author.html_url}}" target="_blank" rel="noopener">
                    <img alt="{{author.login}}" src="{{author.avatar_url}}" class="onebox-avatar-inline" width="20" height="20">
                    {{author.login}}
                  </a>
                </div>
          
                <div class="lines" title="changed {{files.length}} files with {{stats.additions}} additions and {{stats.deletions}} deletions">
                  <a href="{{html_url}}" target="_blank" rel="noopener">
                    <span class="added">+{{stats.additions}}</span>
                    <span class="removed">-{{stats.deletions}}</span>
                  </a>
                </div>
              </div>
            </div>
          </div>
          
          {{> github/github_body}}

david · October 15, 2019, 10:09pm

Yep, exactly @tshenry. I must have copy/pasted it from the PR onebox.

I’ll fix and bump onebox now

Topic		Replies	Views
Github onebox does not point to individual commits in PR links Bug	3	977	June 22, 2017
Onebox of github commits overview is just the onebox of the first commit Feature pr-welcome	3	1019	October 9, 2019
New dashboard link to commit diff is odd UX	3	841	October 17, 2019
Github - There isn’t anything to compare Support	4	1598	January 22, 2022
Convert GitHub commit hash to a link Feature ai	0	402	October 31, 2023

GitHub diff stat link for commits results in 404 link

STR

What happens

What should happen

Other

Related topics