GitHub Plugin: Support for Issues

Glad to see a PR recently added to use the GitHub API for badges thanks to @Osama.

I know that previously @codinghorror has said that issue linkback support won’t be added as Discourse doesn’t use GitHub issues but we at Home Assistant do with no plans to migrate away from GitHub issues anytime soon (no matter how much we love Discourse!). Would a PR be accepted if I submitted one to enable linkbacks for issues too? I’d be more than happy to make it opt in via a setting.

3개의 좋아요

I am not against adding this as a default off option, but first i want to see a mock of how this would work.

  1. How will it look on GitHub?

  2. What site settings are you talking about adding.

2개의 좋아요
  1. I think it would look exactly the same as it does on a PR. Just a comment on the issue with the same text (This issue has been mentioned on Discourse Meta. There might be relevant details there.\n\n\<link>). Maybe you are thinking of a reason that you may think that text would need to change as it’s extremely likely I am not thinking all reasons through.

  2. I’d say just one setting titled “github linkback on issues enabled” with a checkbox.

3개의 좋아요

Hi there :wave: first post on the discourse meta discourse… thanks for making a wonderful product!

I’m just here to offer my :+1: for GitHub Issue linkbacks. This would be huge for my team!

4개의 좋아요

저도 한마디 보태자면, 커밋과 PR에서와 마찬가지로 GitHub Issues에서도 동일한 동작을 하는 이 기능을 보고 싶습니다.

2개의 좋아요

여기서 특정 기능에 대한 지원을 추가하는 PR을 환영합니다. 보안을 올바르게 설정하는 것은 까다로운 문제인데, discourse 코드 리뷰에서는 토큰을 사용하는 방식으로 처리하고 있습니다. 단, 본인의 토큰이 아니라, 귀하가 신경 쓰는 저장소에 접근 권한이 없는 일회용 GitHub 계정의 토큰을 사용해야 합니다.

3개의 좋아요

게시글이 새 주제로 분리되었습니다: Add support for issues to the discourse code review plugin