Google Maps embeded links sometimes work, sometimes don't (onebox 404)

Canapin · 11월 2, 2022, 11:57오전

Google Maps 링크에서 이상한 동작이 발생하고 있습니다.

때로는 제대로 임베드되기도 하고, 때로는 onebox 요청이 404를 반환하기도 합니다. 문제를 일관되게 재현하는 방법을 찾지 못했지만, 매우 자주 발생합니다. 링크를 붙여넣거나, Google Maps 카메라를 이동하거나 크롭을 한 뒤 다시 시도해 보세요…

처음에는 레이트 리밋(rate limit) 문제인 줄 알았지만, 그렇지 않습니다. 동작하는 링크와 동작하지 않는 링크는 제 환경에서도, 제 포럼에서도 동일합니다. 예시:

이 문제가 어디서 발생하는지 아이디어가 있는 분이 있을까요? Google 측 문제인가요, Discourse 측 문제인가요? Contribute > Bug 채널로 옮기는 것이 적절할까요?

awesomerobot · 2월 21, 2023, 9:07오후

This is kind of weird, I just happened to notice the pattern… but I think it has something to do with the zoom level in the link?

15.5z

15z

16.75z

17z

An entirely different location…

15.38z

15z

My guess is that it’s a Google Maps onebox engine issue on our end?

Falco · 2월 21, 2023, 10:02오후

Nice sleuthing @awesomerobot !

Looks like our regex for zoom level doesn’t allow dots here:

github.com/discourse/discourse

lib/onebox/engine/google_maps_onebox.rb

main


      
              break if type != :standard
              sleep 0.1
            end
          end
          
          case type
          when :standard
            # Fallback for map URLs that don't resolve into an easily embeddable old-style URI
            # Roadmaps use a "z" zoomlevel, satellite maps use "m" the horizontal width in meters
            # TODO: tilted satellite maps using "a,y,t"
            match = @url.match(/@(?<lon>[\d.-]+),(?<lat>[\d.-]+),(?<zoom>\d+)(\.\d+)?(?<mz>[mz])/)
            raise "unexpected standard url #{@url}" unless match
            zoom = match[:mz] == "z" ? match[:zoom] : Math.log2(57280048.0 / match[:zoom].to_f).round
            location = "#{match[:lon]},#{match[:lat]}"
            url = "https://maps.google.com/maps?ll=#{location}&z=#{zoom}&output=embed&dg=ntvb"
            url += "&q=#{$1}" if match = @url.match(%r{/place/([^/\?]+)})
            url += "&cid=#{($1 + $2).to_i(16)}" if @url.match(/!3m1!1s0x(\h{16}):0x(\h{16})/)
            @url = url
            @placeholder =
              "https://maps.googleapis.com/maps/api/staticmap?maptype=roadmap&center=#{location}&zoom=#{zoom}&size=690x400&sensor=false"
          when :custom

Quite an easy fix.

Canapin · 2월 22, 2023, 12:01오전

What a catch

Thanks for figuring it out!

zogstrip · 2월 28, 2023, 9:36오후

@loic can you have a quick look at this one?

loic · 3월 1, 2023, 8:07오전

Sure, I’ll take a look

loic · 3월 1, 2023, 11:46오전

Fixed here:
https://github.com/discourse/discourse/pull/20497

zogstrip · 3월 2, 2023, 9:39오전

Rebuilding @awesomerobot’s post and all the Google Maps links are now working

Closing this.

글		댓글	조회수
Google Maps Onebox Issue Support	4	2341	5월 3, 2019
Google Maps onebox issues Bug	15	3620	1월 1, 2016
Embedding google maps short urls is broken Feature	9	7071	3월 22, 2015
Embedded google map stopped working Support	10	4790	9월 30, 2020
Google maps link not embedding anymore Support	2	668	9월 12, 2022

Google Maps embeded links sometimes work, sometimes don't (onebox 404)

Related topics