The “Granted By” staff name is not being displayed on manually issued badges in Discourse version 3.2.0.beta2-dev. Richie reported this issue and shared a screenshot. Don suggested that the granter name might only be recorded for system_users and not for staff, but Arkshine found that the template is ready to display the granter name, but the code expects the payload to include a list of users which is not implemented.
Don shared a relevant commit and Richie found the related meta topic discussion. JammyDodger recovered the deleted discussion thread. kelv fixed the issue in a pull request. Richie thanked kelv and asked if it was a bug or an unimplemented feature. kelv was unsure but implemented the fix as it seemed to be the intended feature. The fix is now working as shown in Richie’s screenshot.
Hello everyone.
Discourse version 3.2.0.beta2-dev (1a70817962)
When manually issuing badges to our members via the admin pages, the “Granted By” staff name is not being displayed:
Possibly related to: Grant badge reason not added to the granted badge 
Hello 
If I now it correctly it only record here the system_users. If a staff grant a badge to a user than it place to the Staff Action Logs. /admin/logs/staff_action_logs
However I think it would be a great feature to add this to the manually granted badges by staff.
It shows any records created by staff as well. You’re right for the log.
From what I see, the template is ready to display the granter name, but the code expects the payload (creation and listing) to include a list of users so the name can be figured out based on the granter ID. I think it has never been implemented.
This commit is probably relevant I think Unfortunately the meta topic discussion about it is not available anymore.
https://github.com/discourse/discourse/pull/6266
Is it not this one?
I raised it from the dead after I read Don’s comment this morning. 
Ahhhh, I thought I’d gained extra special privileges or something 
Thanks for reporting this, fixed in FIX: display and link to correct grant_by users for granted badges by tyb-talks · Pull Request #24021 · discourse/discourse · GitHub
Brilliant, thanks @kelv 
@kelv going by the FIX commit message, was this actually a bug then?
Rather than just something that wasn’t implemented?
I was never able to find a breaking commit so I’m unsure if it was a planned feature that was never implemented or a bug 
Either way, I figured that the UI seemed to have the explicit intention to have this in place (going by the Granted By column header) so I opted to go with FIX.
This topic was automatically closed after 2 days. New replies are no longer allowed.
