在频道名称中有右括号会破坏该频道的所有引用

Firepup650 · 2024 年5 月 17 日 15:09

示例，附带虚假频道数据：

Someone random

#Some cool channel

此引用工作正常

Someone random

#[Some cool channel]

此引用无法正常工作

zogstrip · 2024 年5 月 24 日 08:57

感谢您的报告 @Firepup650
我想是时候我们终于做了

github.com/discourse/discourse

app/assets/javascripts/discourse-markdown-it/src/features/bbcode-block.js

c39a4de13


      
              closed = true;
              break;
            }
          }
          
          if (closed) {
            length = i - start + 1;
          
            let raw = src.slice(start + tag.length + 1, i);
          
            // trivial parser that is going to have to be rewritten at some point
            if (raw) {
              let match, key, val;
          
              while ((match = ATTR_REGEX.exec(raw))) {
                if (match[1]) {
                  key = "_default";
                } else {
                  key = match[4];
                }

一旦这个 PR 被审查和合并就会得到修复

github.com/discourse/discourse

FIX: BBCode tag parser

main ← fix-bbcode-parser

opened 08:48AM - 24 May 24 UTC

ZogStriP

+230 -344

Wasn't quite handling the cases where a closing bracket `]` was used in the valu…e of one of the attributes. ```markdown [chat quote=user channel="[broken]"] ``` Would not be correctly parsed because we would _greedily_ use the first `]` as the end of the tag even though it might be a valid character when inside proper quotes. https://github.com/discourse/discourse/blob/c39a4de139ed9bba4696d44b15cb7569038b5fde/app/assets/javascripts/discourse-markdown-it/src/features/bbcode-block.js#L62 Re-wrote the `parseBBCodeTag` to properly handle the following cases - A closing tag (aka `[/name]`) which are easy since they don't have any attributes - An old `[quote=...]` format we used that doesn't uses quotes but still has various attributes of the form `key:value` - All three valid BBCode opening tag formats we support - `[name]` without any attributes - `[name=foo]` with a default value - `[name foo=bar]` with some attributes Ended up having to fix/rewrite the few bbcode rules that were using the `parseBBCodeTag` function, namely `d-wrap` and `discourse-local-dates`. While working on this, I think I also found a way to get rid the of shims we had in place so that plugins could use the `parseBBCodeTag` function. Reference - https://meta.discourse.org/t/having-a-right-bracket-in-a-channel-name-breaks-all-quotes-from-that-channel/308439

Peter_Baehr · 2024 年6 月 4 日 16:15

在发现与文件上传相关的错误后，我遇到了这个错误/修复。如果文件名包含“]”字符但前面没有“[”，它会破坏格式并且不会生成链接。我怀疑在这里修复 BBCode 解析器也能解决该问题，但以防万一在其他地方进行了解析，我还是提到了这一点。

zogstrip · 2024 年6 月 18 日 10:38

PR 已合并，已在此处部署，并且 OP 已重新烘焙

JammyDodger · 2024 年6 月 21 日 10:43

此主题已在 3 天后自动关闭。不再允许回复。

话题		回复	浏览量
Fix quotes after phpBB import Support	81	6896	2024 年6 月 8 日
Quotes in full name mess up quote markdown Bug	4	56	2025 年12 月 18 日
BBCode [quote] tag and mixed newlines Feature	4	1321	2022 年1 月 26 日
Tag name with single quote causes server error Bug	5	2422	2020 年8 月 3 日
BBcode [url] deletes parts of a link Bug	2	891	2017 年7 月 20 日

在频道名称中有右括号会破坏该频道的所有引用

相关话题