Don
13 Novembre 2024, 6:23am
1
Ciao
Ho trovato alcuni punti in cui penso che dovrebbe nascondere anche la presenza online.
Presenza chat, quando scrivi un messaggio viene visualizzata in basso anche se nascondi la tua presenza.
Penso che nel riepilogo della pagina utente, nelle statistiche, l’opzione “Visto” dovrebbe essere nascosta anche agli utenti se l’opzione “Nascondi presenza” è attiva.
Sarebbe anche utile se funzionasse come il punto 2 con il componente tema “Ultimo visto” Scheda utente .
Grazie
4 Mi Piace
lindsey
21 Novembre 2024, 3:35pm
2
Grazie per aver condiviso queste idee! Sposterò questo in Feature
1 Mi Piace
Don:
Presenza chat, quando scrivi un messaggio viene mostrata in basso anche se nascondi la tua presenza.
Questo verrà risolto da
main ← fix-is-replying-when-offline
opened 06:57PM - 03 Dec 24 UTC
While trying to reproduce an issue reported internally where a user saw the "is … replying..." from another user who had disabled presence (aka. was "offline"), I noticed something odd about the way we "notify" presence via `notifyState`. The way it is setup up, it's being called on every "input" event in the composer/editor, due to it tracking the "reply" property of the composer model. That's fine, but the way the `helperFn` helper works, make it so we're calling the `on.cleanup` callback also on **every** "input" events in the composer/editor. For every character we enter in the composer, we're "entering" the presence channel and immediatelly "leaving" it...
If I remove the checks on `reply` (and thus the auto-tracking), then the `notifyState` function is called much less frequently. But we have some specs that expects us not to "publish" our presence when we open the composer and the reply is "empty".
Note: I switched to using `replyDirty` instead to re-use the checks the composer model is already doing to ensure we actually have changed something in the reply.
The best I came up with was not to rely on the `helperFn` but now, there's no way (that I could find) to call `composerPresenceManager.leave()` when the composer is closed. I tried a lot of different ways, but none worked. I'm sure it's something stupid easy, but I can't figure it out just now.
Internal ref - t/127490/74
(una volta che riuscirò a farlo funzionare correttamente
2 Mi Piace
La presenza della chat dovrebbe rispettare l’interruttore online/offline ora che utilizza lo stesso “gestore di presenza” del “core”.
committed 11:21AM - 04 Dec 24 UTC
...since it was mostly duplicating the work the "ComposerPresenceManager" was do… ing.
So now the #chat composer uses the same "presence manager" as the composer, benefiting from the "hide presence" checks, with the only difference that the "keep alive" timeout is 5s for chat and 10s for topics/posts.
4 Mi Piace
)