I have a working carousel which I would like to package as a theme: [image] I’ve been trying to figure out how to whitelist a class or attribute for the script to target that would work with under a theme. I’ve read: https://meta.discourse.org/t/whitelisting-some-html-tags/24280 and Whitelist …

Oh you can not do that yet, what I would like to do is just have .theme-[a-z]+ automatically whitelisted, but it requires fiddling with the whitelister a bit. Assigning this to me, but may take a few weeks to get around to it. If @angus or @david feel like giving it a shot, be my guest.

No worries @sam :sunflower: Thank you for taking this on - no rush at all I’m sure your plate is full :sweat_smile: I have one last followup question. Does defining new tags like: [foo] // slides [/foo] to be later converted into <div class="foo"> // slides </div> in the cooked output also r…

Yeah if you are trying to amend the markdown pipeline I think you need a plugin. One thing that is good security wise with themes is that they are not allowed to run on the server, this would change it.

I spent a bit more time trying out different things and here's what I found 1- <div dir="foo"></div> is not filtered out even if the value does not match rtl or ltr 2- <div dir></div> is also not filtered out This line has can be selected with [dir="foo"] This line can be selected with div[dir=…

Wow, this looks fantastic. Really hoping this sees the light of day.

I wonder if we could adopt this somehow GitHub - markdown-it/markdown-it-container: Fenced container plugin for markdown-it markdown parser Maybe under a site setting or a plugin.

In general we do blocks in bbcode, so it gets a bit confusing to add another pattern. The issue here is the whitelister per: https://github.com/discourse/discourse/blob/master/app/assets/javascripts/pretty-text/white-lister.js.es6#L114-L179 But our DSL is a bit too limited atm to add theme-* as a…

<aside data-carousel="true"></aside> Would also work. [Capture] And unlike <div dir="foo"></div> or <div dir></div> <aside data-carousel="true"></aside> is valid html Still feels a bit unorthodox though :no_mouth:

Oh, I can add data-* to div quite easily, does that help?

[image] sam: Oh, I can add data-* to div quite easily, does that help? Yes! :fire: I think that would work and pretty much cover everything. attribute selectors work with jQuery and CSS just fine. :wine_glass:

Comment puis-je autoriser une classe dans un thème ?

Dev

Johani (Joe) Février 15, 2018, 8:48 16

This is great news!

Well I tried anyway

https://github.com/discourse/discourse/pull/5598

PR submitted

User styled posts?

Sujet		Réponses	Vues
Whitelisting elements in Discourse Plugin Development	5	1071	Décembre 9, 2022
Post HTML Element Class Being Removed Support	11	2618	Août 30, 2022
How to add a class attribute to a table created using markdown Support	14	5640	Juin 8, 2024
Whitelisting HTML tags / attributes Support	3	1874	Août 3, 2020
HTML Whitelisting Development	0	498	Mai 3, 2020

Comment puis-je autoriser une classe dans un thème ?

Sujets connexes