Come trovare tutte le immagini mancanti?

Supporto
22

I also have a lot of missing images:

root@xxxxx-app:/var/www/discourse# rake posts:missing_uploads

37 post uploads are missing.

34 uploads are missing.
5 of 34 are old scheme uploads.
33 of 1013268 posts are affected.

but after

root@xxxxx-app:/var/www/discourse# rake uploads:missing
.
.
.

/var/www/discourse/public/uploads/default/original/2X/3/3a9bf205dec2b6bd0b3cc35a3be1f69499960713.JPG
/var/www/discourse/public/uploads/default/original/3X/2/d/2db0ff326859b94824b64c4e0c2b156c562b7a99.jpg
/var/www/discourse/public/uploads/default/original/3X/e/f/ef271ac232c31e747206b47e4de7e0570de9e030.jpg
**10604** of 101083 uploads are missing

/var/www/discourse/public/uploads/default/optimized/2X/3/3d3efaa44fb43b99ec290b75e289080fc448f709_1_657x500.gif
/var/www/discourse/public/uploads/default/optimized/2X/4/4e3b01361d7c30c3df27a9606271175d91edff6d_1_200x200.jpeg
/var/www/discourse/public/uploads/default/optimized/2X/6/68fcd443312e7c500d25a6067c04c98aa1066686_1_200x200.JPG
/var/www/discourse/public/uploads/default/optimized/2X/1/16452ee2749e93e6b47d1388a20e34c1e3832ee1_1_100x100.jpg
/var/www/discourse/public/uploads/default/optimized/2X/0/0e843544885c0ee7a0c350d66bbe852dd4f0a497_1_135x135.jpeg
/var/www/discourse/public/uploads/default/optimized/2X/f/fb3d38e8d1b0e8ae25606156d37b8045f7cbc2b3_1_200x200.jpg
/var/www/discourse/public/uploads/default/optimized/2X/5/54a076f5be7cfabcf0fa34e57b836d85a33a879e_1_200x200.jpg
7 of 247116 optimized_images are missing
23

I’m having this problem as well on a forum running v2.3.0.beta9. I haven’t restored from backups. It’d be good to know why it’s happening and what we can do to restore the missing uploads. The good news is that the missing uploads seem to be in the tombstone, so hope isn’t lost..

So far, I’ve rebuilt the app and run rake uploads:missing, but that hasn’t helped.

root@forum-app:/var/www/discourse# rake posts:missing_uploads
Looking for missing uploads on: default

146 post uploads are missing.

142 uploads are missing.
81 of 58082 posts are affected.

root@forum-app:/var/www/discourse# rake uploads:missing

Looking for missing uploads on: default

146 post uploads are missing.

142 uploads are missing.
81 of 58082 posts are affected.

The missing uploads are from twoish weeks ago.

24

Problem solved! rake uploads:recover_from_tombstone did the trick. It’d still be good to understand why this happened…

25

@vinothkannans, @zogstrip Any updates on this?

26

Just checking in again. Does anyone know the answers to the following questions from a month ago?

  1. What’s the difference between a missing upload and a missing post upload? (Last I checked, my site appeared to have 196 more of the latter.)

  2. Why does Discourse report images that haven’t been migrated to the new upload scheme as “missing”?

  3. If this is expected behavior, how can I migrate the 200+ images like this on my site to the new upload scheme?

27

@vinothkannans can advise

28
  • missing upload - The upload record is found in DB but the file is missing in the file storage.
  • missing post upload - The upload record is not found in DB for an upload URL in the post.

I think those old scheme uploads are not found in the database and/or filesystem too.

You can do it by enabling the setting using the below command. It will migrate those upload if they’re found in DB and filesystem.

SiteSetting.migrate_to_new_scheme = true
29

Forgive me.. where do we load these?

30

You need to enter that into the rails console as it’s a hidden site setting.

31

so:

root@site:~# cd /var/discourse/
root@site:/var/discourse# ./launcher enter app
root@site-app:/var/www/discourse# rails c
[1] pry(main)> SiteSetting.migrate_to_new_scheme = true

then exit, and rebuild?

EDIT:

any other steps.. do we need to undo this after?

32

Looks good. No need to rebuild or undo.

33

Thanks, @vinothkannans. :bowing_man:t2:

How will I know that this command has been successful? Should I try running rake posts:missing_uploads again after enabling this hidden site setting in the Rails console? Or maybe PostCustomField.where(name: Post::MISSING_UPLOADS)?

34

Ci sono aggiornamenti a riguardo?

35

Verrà eseguito e migrato in un job in background. Una volta completato, il valore dell’impostazione del sito SiteSetting.migrate_to_new_scheme tornerà a false. Quindi esegui nuovamente l’attività rake posts:missing_uploads.

36

Ok, ho seguito il tuo consiglio e l’output sembra promettente. Per prima cosa, sono entrato nel contenitore Discourse:

$ cd /var/discourse
$ sudo ./launcher enter app

WARNING: We are about to start downloading the Discourse base image
This process may take anywhere between a few minutes to an hour, depending on your network speed

Please be patient

Unable to find image 'discourse/base:2.0.20190625-0946' locally
2.0.20190625-0946: Pulling from discourse/base
Digest: sha256:9899c60721649460283ac800836ac1ebecbc3ed8a97a496e514cf8c97f5b6d82
Status: Downloaded newer image for discourse/base:2.0.20190625-0946

Poi ho eseguito rake posts:missing_uploads:

# rake posts:missing_uploads
Looking for missing uploads on: default
Fixing missing uploads: 
.........................................................................................................................................................................................................................................................
12 post uploads are missing.

12 uploads are missing.
1 of 12 are old scheme uploads.
3 of 8930 posts are affected.

(Quest’volta solo 12 upload di post mancanti! Ottimo!)

Infine, ho impostato SiteSetting.migrate_to_new_scheme a true ed exitato dalla console Rails:

# rails c
[1] pry(main)> SiteSetting.migrate_to_new_scheme
=> false
[2] pry(main)> SiteSetting.migrate_to_new_scheme = true
=> true
[3] pry(main)> exit

Dopo un po’ di tempo, ho confermato che il valore di SiteSetting.migrate_to_new_scheme era effettivamente diventato false e ho rieseguito rake posts:missing_uploads:

[1] pry(main)> SiteSetting.migrate_to_new_scheme
=> false
[2] pry(main)> exit
# rake posts:missing_uploads
Looking for missing uploads on: default
Fixing missing uploads: 
.
12 post uploads are missing.

12 uploads are missing.
1 of 12 are old scheme uploads.
3 of 8939 posts are affected.

L’output è più o meno lo stesso, quindi penso che questo significhi che tutti i post che utilizzavano lo schema di upload vecchio sono stati migrati al nuovo schema. Tuttavia, la directory uploads contiene ancora molte sottocartelle numerate:

$ cd /var/discourse/shared/standalone/uploads/default/
$ ls
1    112  125  138  151  164  177  190  203  216  229  242  255  268  281  294  46  59  72  85  98
100  113  126  139  152  165  178  191  204  217  230  243  256  269  282  34   47  60  73  86  99
101  114  127  140  153  166  179  192  205  218  231  244  257  270  283  35   48  61  74  87  optimized
102  115  128  141  154  167  180  193  206  219  232  245  258  271  284  36   49  62  75  88  _optimized
103  116  129  142  155  168  181  194  207  220  233  246  259  272  285  37   50  63  76  89  original
104  117  130  143  156  169  182  195  208  221  234  247  260  273  286  38   51  64  77  90
105  118  131  144  157  170  183  196  209  222  235  248  261  274  287  39   52  65  78  91
106  119  132  145  158  171  184  197  210  223  236  249  262  275  288  40   53  66  79  92
107  120  133  146  159  172  185  198  211  224  237  250  263  276  289  41   54  67  80  93
108  121  134  147  160  173  186  199  212  225  238  251  264  277  290  42   55  68  81  94
109  122  135  148  161  174  187  200  213  226  239  252  265  278  291  43   56  69  82  95
110  123  136  149  162  175  188  201  214  227  240  253  266  279  292  44   57  70  83  96
111  124  137  150  163  176  189  202  215  228  241  254  267  280  293  45   58  71  84  97

Qual è il modo più semplice per capire quali (se ce ne sono) post fanno riferimento alle immagini in quelle sottocartelle? Una semplice query dalla console Rails va bene.

Grazie!

37

Potrebbe contenere anche molte directory vuote. Credo che dovresti ignorarle tutte.

La query sottostante può aiutarti.

Post.where("cooked LIKE '%/uploads/default/%' AND cooked NOT LIKE '%/uploads/default/original/%' AND cooked NOT LIKE '%/uploads/default/optimized/%'")
38

quell’output è infinitamente lungo e non vedo un modo semplice per inoltrarlo a un file per l’elaborazione. (Il meglio che posso fare è premere la barra spaziatrice per avanzare pagina per pagina… e non ho ancora visto la fine).

Come potremmo ottenere quell’output in un file, o magari farlo saltare il corpo del messaggio/allegati?

39

Ok, abbiamo trovato un modo, uno che evita l’output delle tre colonne “più problematiche”:

"raw", "cooked", "raw_email

posts = Post.where("cooked LIKE '%/uploads/default/%' AND cooked NOT LIKE '%/uploads/default/original/%' AND cooked NOT LIKE '%/uploads/default/optimized/%'"); 42
CSV.open("/tmp/posts-to-review.csv", "wb") do |csv|
  csv << Post.attribute_names - ["raw", "cooked", "raw_email"]
  posts.each do |post|
    csv << post.attributes.except("raw", "cooked", "raw_email").values
  end
end
  • Salta la stampa dell’output digitando q,
  • Esci da Ruby con exit
  • Pulisci lo schermo, poi usa cat /tmp/posts-to-review.csv

Immagino che avrei potuto indirizzarlo alla cartella condivisa… ma questo funziona.

(modificato per aggiungere passaggi più chiari)

40

Hmm… l’ho appena controllato (usando find . -maxdepth 1 -type d -empty | wc -l) e ho trovato solo 19 directory numerate vuote su un totale di 262 (usando find . -maxdepth 1 -type d -iname '[0-9]*' | wc -l), ovvero circa il 7%. Quindi non penso che dovrei ignorarle completamente?

Ottimo, grazie! :+1:

Ho notato che questo utilizza l’attributo “cooked”—presumibilmente ciò significa che la sorgente Markdown potrebbe continuare a utilizzare il vecchio schema di caricamento? Ad esempio, ho trovato un post che ha questo tag immagine nella sorgente:

<img src="/uploads/default/293/8d45810f8911c08c.jpg" width="666" height="500">

Tuttavia, se passi il mouse sopra l’immagine renderizzata, il link punta al seguente URL:

/uploads/default/original/2X/0/0d1e04b9215f210faf1d8509e6bede9c3319e02b.jpeg

Dovremmo preoccuparci del fatto che gli URL delle immagini nella sorgente Markdown non corrispondano agli URL delle immagini nell’HTML “cooked” (inclusi gli hash dei file)? Ad esempio, potrei eliminare in sicurezza la directory /var/discourse/shared/standalone/uploads/default/293 senza preoccuparmi di interrompere il link all’immagine sopra? O, per dirla in un altro modo, Discourse saprà sempre che /uploads/default/293/8d45810f8911c08c.jpg è un alias di /uploads/default/original/2X/0/0d1e04b9215f210faf1d8509e6bede9c3319e02b.jpeg, e questa mappatura verrà preservata quando il sito viene ripristinato da un backup?

41

Sì. L’URL non dovrebbe essere diverso tra la versione grezza e quella elaborata. Puoi incollare qui il contenuto testuale completo delle colonne raw e cooked del post?