Because message revisions are kept, and older removed messages are also kept, and even removed topics are still there in database, how do I make an image orphaned so it gets removed automatically by a sidekiq job?

All the details are available in this job app/jobs/scheduled/clean_up_uploads.rb main # frozen_string_literal: true module Jobs class CleanUpUploads < ::Jobs::Scheduled every 1.hour def execute(args) grace_period = [SiteSetting.clean_orphan_uploads_grace_perio…

I was investigating a case where an upload is not deleted while it belongs to a post that has been deleted over 48 hours ago. But … neither the CleanUpUploads job nor the soft deletion code for a post seem to handle this case ? The job checks for pu.upload_id IS NULL but while an Upload has has_m…

Are you sure that upload isn’t being used elsewhere? Like in a site setting? A category image? A user avatar?

On one hand, keeping the upload helps when restoring the post. On the other hand, this can easily be abused. I think we should update our CleanUpUploads job to remove uploads only referenced in a soft-deleted post older than 1 week. @codinghorror / @sam what do you think?

I am traumatised from losing of uploads, my blog just lost a pile of images on early posts due to a bug we had. I think we should simply start with a rake task people can run to reclaim the space taken up by images on deleted posts (and posts on deleted topics) we can then decide what to do longer …

I’m going to play the GDPR violin here. It’s not just about reclaiming space - it’s also about being able to remove personal data. Right now many users will think they removed the post including the uploads, while they didn’t. Even soft-deleting the post and hard-deleting the images would not always…

@sam wants removal of uploads from deleted posts to be a manual rake task for now. I don’t have any particular feelings about it.

I object to the GDPR concern, cause if you are asking for ultra strong post removal then posts need to be hard deleted, in that case uploads go as well, so what you are asking for here is a UI hard nuke. If you must ensure image removal another simple workaround is to edit the image link out of the…

Yeah those were two different solutions, the GDPR concern would indeed need a hard deletion, but if there are objections against that then a soft delete would be a second best. The image link editing is a cool workaround, thanks for the tip!

[imagen] sam: I object to the GDPR concern I am in a situation where I can’t ignore it. On my instance, our users constantly exchange sensitive data via PM’s such as IDs and documents. They were under the impression that once deleted, they’re gone. I gave them that impression via our rules an…

How to make an image orphaned so that it gets removed?

Soporte

Falco (Falco) Separó este tema 27 Febrero, 2019 03:46 18

A post was split to a new topic: How to truly delete topics

Tema		Respuestas	Vistas
Auto purge uploads from old deleted posts Feature	6	1122	23 Febrero 2026
Help deleting photos from server that were attached to deleted posts Support	3	362	3 Febrero 2024
Uploads not getting orphaned and purged Support	9	1534	19 Abril 2024
Cleaning up uploads and purging uploads from S3 Site Management reference , file-management	2	1064	24 Diciembre 2024
Removing post not removing its image from bucket Support	4	576	14 Septiembre 2021

How to make an image orphaned so that it gets removed?

Temas relacionados