Ik kan maar één woord citeren

AI-generated summary

Users are discussing an issue where Moin is only able to quote a single word when using Firefox on their Galaxy Tab S9 FE ([/t/-/369911/6]) running Android 14 and Firefox 139.0.4 ([/t/-/369911/4]). The problem started after a recent Discourse commit ([/t/-/369911/1]) aimed at improving text selection ([/t/-/369911/1]).

joffreyjaffeux has been actively investigating, attempting to reproduce the issue on various Samsung Galaxy Tabs running different Android versions ([/t/-/369911/3], [/t/-/369911/5], [/t/-/369911/7]). The issue seems to be related to the Discourse view, working correctly in mobile view ([/t/-/369911/8]).

joffreyjaffeux identified some related issues and began working on a fix, deploying a test branch with toolbar rework ([/t/-/369911/14]). Initial testing by Moin indicates the fix resolves the quoting problem, although a minor bug requiring a double press of ‘e’ for fast editing was also noted ([/t/-/369911/14]). Further adjustments were made to discourse-ai helper ([/t/-/369911/13]). Thanks for testing from joffreyjaffeux.

When I try to quote something using Firefox on my tablet, I only get one word.
It was working when I posted 4 hours ago, but now it doesn’t work anymore.


I have tried safe mode and a private tab to eliminate browser plugins.

I noticed there was a recent commit which should improve the text selection: https://github.com/discourse/discourse/pull/33143
Could this be the cause?

3 likes

Which android version please? and maybe firefox version?

No repro on Samsung Galaxy Tab S10 Plus v15.0.

1 like

Android 14, Firefox 139.0.4

1 like

Also no repro on Samsung Galaxy Tab A9 Plus v14.0.

This is a Galaxy Tab S9 FE

No repro on Samsung Galaxy Tab S9 v13.0 :man_shrugging:

When I switch Discourse to mobile view using the button in the sidebar, it works. But as soon as I switch back, it’s broken again.

Ok I can’t repro the exact same thing, but I see issues, will try to work from here.

2 likes

We are testing a branch internally, if all goes well I will merge this tomorrow.

2 likes

Hier wordt nog aan gewerkt, we brengen enkele wijzigingen aan in de discourse-ai helper om dingen hier gemakkelijker te maken om te wijzigen.

1 like

@Moin Ik heb zojuist meta op een specifieke branch gedeployed die de werkbalk opnieuw ontwerpt, kun je het proberen en me laten weten hoe het voor je gaat alstublieft?

(één kleine bug die ik weet, is dat je nu twee keer op e moet drukken voor snelle bewerking, dit zal ik oplossen)

2 likes

I have just quoted several times, it has always worked. :+1:

I usually don’t have a keyboard connected to my tablet anyway

2 likes

Geweldig, bedankt voor het testen.

2 likes