A user, nolo, reported that icons in the sidebar do not show up when the color is not defined. They suggested that icons should show with the default icon color for the sidebar, allowing users to define a static color if desired. pmusaraj agreed and invited a pull request (PR) to fix the issue. nolo submitted a PR, which was merged by pmusaraj. However, this change caused icons with defined colors to render in gray. md-misko pointed out the issue and requested a test for categoryColour to avoid breaking existing definitions. Don suggested a workaround by removing the categoryColor field. nolo acknowledged the issue and submitted another PR to fix the regression.
What seems a small glitch: Icons don’t show, when the color is not defined. E.g. on this screenshot the first category has an icon defined, but no color. Then the icon is not shown:
The downside to defining all icons with colors is that icons then won’t show with inherited colors on the list views (accent when the topic is unread/ dimmed down when the topic is read). E.g. here the Announcements icon shows with inherited color, while as the icon with defined color always stays the same:
I think icons should just show on the sidebar with the default icon color for the sidebar. Then it’s up to the user if they want to define a static color or not.
Yes, but it breaks the existing definitions (I have quite a few).
@manuel Would you be so kind and include the test for categoryColo(u)r so that we don’t need to manually fix all definitions in all existing instances? Thanks in advance!
Ok, there’s quite some stuff going on here with colors
So actually the declaration is obsolete on both the default badges and on the sidebar. Just on the default badges it fails silently as it’s applied to an inline style:
