Incorrect staff sheild on user card

##Steps to reproduce

  1. Clicking to staff members user avatar to display user card
  2. Note the display of the staff shield
  3. Click non-staff member user avatar to display user card

##Expected result
Non-staff member user card should not include shield icon

##Actual result
Non-staff member user card includes shield icon

8개의 좋아요

I can repro here trivially, I wonder if we regressed this today @eviltrout ?

1개의 좋아요

Perhaps a regression related to unified display output for emails? Maybe have a look tomorrow @eviltrout

Note that the converse also seems true and you can get Admins without the badge if you click in the reverse sequence.

1개의 좋아요

This should fix it up real nice:

https://github.com/discourse/discourse/commit/5f8bd16e7e153cd7acfc523da206cb0f993ba9bf

5개의 좋아요