Intra-post anchor links don't work in Safari / Firefox

plkap74 · 5월 22, 2015, 1:19오후

I’ve been experimenting with anchor links inside of posts (links to content inside of a long post). I have read that you can’t use the ids because they get stripped. I used the name property instead and it works for Chrome but throws a very cryptic error in Safari.

Error: Syntax error, unrecognized expression: [name=anchor-name

It doesn’t give a useful trace so I can’t even tell where it is coming from. Is the anchor routing dealt with by Ember? Is there custom logic for that somewhere?

Example 1 (Live bug)

Try going to this link in Chrome (it works) but in Safari it throws an error and doesn’t work:

Example 2 (Reproduced bug)

works in Chrome, throws errors in safari


      
            if ENV["SPROCKETS_CONCURRENT"] == "1"
              concurrent_compressors = []
              executor = Concurrent::FixedThreadPool.new(Concurrent.processor_count)
          
              yield(
                Proc.new do |&block|
                  concurrent_compressors << Concurrent::Future.execute(executor: executor) { block.call }
                end
              )
          
              concurrent_compressors.each(&:wait!)
            else
              yield(Proc.new { |&block| block.call })
            end
          end
          
          def current_timestamp
            Process.clock_gettime(Process::CLOCK_MONOTONIC)
          end
          
          def log_task_duration(task_description, &task)

plkap74 · 5월 26, 2015, 12:44오후

I’m sorry I should have been more specific, I meant where was the name anchor code happening. I dove in and found it in javascripts/discourse/lib/url.js. It looks like there is a missing bracket.

github.com/discourse/discourse

app/assets/javascripts/discourse/lib/url.js

f496982e7


      
          },
          
          // Scroll to the same page, different anchor
          scrollToId: function(id) {
            if (Em.isEmpty(id)) { return; }
          
            jumpScheduled = true;
            Em.run.schedule('afterRender', function() {
              var $elem = $(id);
              if ($elem.length === 0) {
                $elem = $("[name=" + id.replace('#', ''));
              }
              if ($elem.length > 0) {
                $('html,body').scrollTop($elem.offset().top - $('header').height() - 15);
                jumpScheduled = false;
              }
            });
          },
          
          /**
            Our custom routeTo method is used to intelligently overwrite default routing

Not sure why that would break only production though…

I’ll submit a PR.

plkap74 · 5월 26, 2015, 12:53오후

PR submitted

https://github.com/discourse/discourse/pull/3503

글		댓글	조회수
Status of anchor link bug Feature	3	2341	7월 21, 2016
Header Dropdown navigation menu custom link removes heading anchor from URL Bug	2	479	3월 20, 2024
Anchor links not working within Discourse - but work from outside the topic Bug	6	210	3월 15, 2026
Anchors Not Working Across Posts Within Topic Bug	11	737	10월 1, 2022
Hash/anchors are being stripped from URLs on mobile. How to stop that? Support mobile	9	270	7월 27, 2026

Intra-post anchor links don't work in Safari / Firefox

Example 1 (Live bug)

Example 2 (Reproduced bug)

Table of contents

Topic 1

Topic 2

TOC Markup

Intra-post anchor links don't work in Safari / Firefox

Example 1 (Live bug)

Example 2 (Reproduced bug)

Table of contents

Topic 1

Topic 2

TOC Markup

Related topics