as per Cannot invite a group to a message - #9 by sam (fantastic feature btw!)
this doesn’t get updated to reflect sales is now part of the message (reopening shows it fine though)
AI-generated summary
The “Invite group” feature in Discourse does not update to reflect added groups. carlokok reported this issue, and sam acknowledged it as a bug.
However, sam explained that users already in the group are intentionally hidden from the invite list, which can make the live adding feature tricky. carlokok understood the reasoning behind this design choice.
sam fixed the issue with the group invite feature through a commit on GitHub, but chose not to remove implicitly invited users from the explicit list to avoid confusion.
1개의 좋아요
Yeah … same for inviting users, seemed buggy on local, will fix.
@sam seems “mh” also disappeared (he’s still there though, I can’t invite him because he’s already there):
That is by design, we suppress users that are in the group from the list of users. Sam is in team so showing Sam and Team is pointless.
which make the “live” adding particularly tricky.
2개의 좋아요
Oh that makes sense.
OK, fixed per:
https://github.com/discourse/discourse/commit/2d425892c492e06f54aaceaf04764c824b5effc2
Not touching the remove implicitly invited users from explicit list on group invite because it will only cause confusion and is tricky to wire up.
6개의 좋아요