iPhone X support in Discourse mobile app

The official Discourse mobile app isn’t expanding to fill the gorgeous screen of iPhone X, sadly.

Hopefully something that can be easily fixed?

Probably won’t be fixed until we release 1.9, as we do app release after each software point release.

Kind of ballsy to call this a “bug”, don’t you think? :wink:

2개의 좋아요

I know… it’s not a bug.. I’m looking at it wrong :relieved:

1개의 좋아요

I would say the “bug” is that someone released new hardware long after our app release :smiley:

6개의 좋아요

So FWIW, it’s not trivial as the app is relying on the old navigation module from react-native, which has since moved to GitHub - react-navigation/react-navigation: Routing and navigation for React Native and Web apps · GitHub

react-navigation has iPhoneX support out of the box, so the issue is more about moving from a deprecated component to the new officially supported.

12개의 좋아요

On the upside, no ugly black handle to stare at cutting through the progress bar

The biggest issue is safari view controller being in tiny mode, I wonder how hard that is to fix

1개의 좋아요

For now, but I guarantee FaceID will be a default on all devices as of iPhone 9 in late 2018 — bye bye home button. This xxxtra tall form factor is here to stay. So as they say

the future is already here, it’s just not evenly distributed

4개의 좋아요

@j.jaffeux can you close once you get the app released

This is already implemented in the app I am running (beta) and works fine

6개의 좋아요

Just got the upgraded mobile app and it’s working well on iPhone X. Thanks! :folded_hands:

5개의 좋아요