JavaScript embedding doesn't add directory slash importing image paths, breaks images

icaria36 · March 17, 2018, 2:25pm

This looks like… a simple bug?

Example source page: http://surtdelcercle.cat/index.php?view=blog&id=6
Images are called with relative paths: src="media/torbrowser.jpg"
Resulting URL: http://surtdelcercle.cat/media/torbrowser.jpg (correct)
Imported page: Redirecting... (notice the broken images)
The imported image URL: http://surtdelcercle.catmedia/torbrowser.jpg (broken)

Note the slash missing in “catmedia”.

I didn’t find a report for this bug, although this one might be related: https://meta.discourse.org/t/embedded-topics-dont-handle-images-properly/37355

Can anyone reproduce? Or is there a fix that we could implement on our side? (other than defining images with absolute URLs, which we could do moving forward but what about the articles already published)

pfaffman · July 31, 2020, 8:49pm

Well, it’s been a while, but yes.

github.com/discourse/discourse

app/models/topic_embed.rb

0b3f96380


      
            fragment.css('img').each do |a|
              src = a['src']
              if src.present? && src.start_with?('/')
                a['src'] = "#{prefix}/#{src.sub(/^\/+/, '')}"
              end
            end
            fragment.at('div').inner_html
          end

The above code appears to normalize image URLs that start with a / (fixing up the hostname), but not those relative to the current URL.

Maybe that should instead be this?

    if src.present? && !src.start_with?('http')

If I’m right, I think that the code a few lines above has the same bug.

Topic		Replies	Views
Images not showing when topic is created from embedded comments on site site Bug	9	930	November 17, 2021
Use absolute links for images Feature	4	1789	January 29, 2021
Images not loading - Possible HTTPS issue Product Support	2	1139	April 28, 2020
Image upload, relative path instead of full path Product Support	5	1219	February 1, 2018
Can emoji be rendered with absolute URLs? Bug	5	1422	July 15, 2016

JavaScript embedding doesn't add directory slash importing image paths, breaks images

AI-generated summary

Related topics