שמור על תאימות Rails 6 עבור גרסת "יציבה"

תמיכה
1

Hi !
Changes in commit FEATURE: Allow excluding groups from leaderboards (#37) · discourse/discourse-gamification@ac393c7 · GitHub, file db/migrate/20220623182333_add_excluded_groups_to_leaderboards.rb breaks when upgrading on a “stable” Discourse install.

It happened previously in calendar plugin and fixed by this commit : FIX: Stable core still needs a 6.1 migration (#285) · discourse/discourse-calendar@259f7bf · GitHub

Could you bring back compatibility please ?

By the way, i did not see any branch or tag for plugins. Would it be nice to get a “stable” version of plugins like for Discourse ?

לייק 1
2

There is .discourse-compatibility and when that is not honored we at Communiteq keep a large amount of working forks for stable on https://github.com/discourse-plugins/

3 לייקים
3

discourse-gamification is a very new plugin, we do not expect to support it on the stable version of discourse. The first officially supported stable version will be on the next release of Discourse.

That said @Falco I have been using ActiveRecord::Migration[6.0] in a few places for easy cross compatibility.

לייק 1
4

Otherwise i suppose i can give a git ref on my app.yaml file to pin a precise commit of the plugin no ?

5

Yes, any normal git command or flag will work there.

2 לייקים
6

Didn’t find a convenient git command to do this but this below in container config did the trick :

hooks:
  after_code:
    - exec:
        cd: $home/plugins
        cmd:
          - git clone https://github.com/discourse/discourse-gamification && cd discourse-gamification && git checkout 48b2decfbefda6044953ca0413e45ca3cc18b156
לייק 1
7

Is this commit bringing back compatibility for “stable” version ?

לייק 1
8

I believe so, but perhaps @hyphalos can confirm it’s working for them?

9

I confirm : I updated to the latest commit while in “stable” discourse branch and it is good now

2 לייקים