Let's talk about pictures, quoting pictures in Discourse

We just made a small quality of life change to the new lightbox.

At the top of the lightbox is a new icon :speech_balloon:

Try it here :up_arrow:

When you click it you will quote the image you are looking at and insert into the composer.

Makes it super easy to discuss a particular favorite picture somebody posts!

Enjoy.

27 לייקים

Is it really a good idea to be quoting images? Seems like it would be much better if quoted images were forced to be thumbnails.

לייק 1

We retain the original size, but I hear you, this is what happens when you click magnifying glass twice, maybe we should auto shrink, not sure

לייק 1

It was just the first thought I had since Discourse fairly agressively polices what you can quote to the point of editing something you have already submitted. That’s why it occurred to me that keeping in that vein, it would make sense to default quoted images to something like 30%. The user could always of course change it. But personally I find quoting images more obnoxious that quoting whole posts (Which i admit is also obnoxious, just not so much :grin:)

Nice little QoL update, thanks @sam

One quick observation though; the quoted image loses its extension.

If the original image markup is something like this:

![Image caption|612x470](upload://HASH.png)

the quote it becomes:

![Image caption|612x470](upload://HASH)

It obviously works, there is no problem with it.

However, if ever need to process raw text, do a find & replace, or something similar, omission of the extension may cause a bump, maybe?

3 לייקים

Yeah it is certainly not on purpose, I think we can retain the extension.

@lindsey / @chapoi any thoughts about the size of the image quoted. Should we thumbnail it, or leave it in the original size, I can see arguments either way. (for example if you use it on a grid you probably want to call out an image so keeping it full size by default feels more correct)

3 לייקים

IIRC our implementation doesn’t respect the dimensions or the scale, just the ratio, when building the masonry.

לייק 1

I also can see it either way…

  • Thumbnail keeps things tidier and more compact, so there’s less scrolling required.
  • Original size means that if you haven’t seen the image before (i.e. you haven’t read the quoted post — a real possibility particularly if you’re taking a quote from a different topic), you have just as good of a viewing experience as if you had.

I believe we’re just talking about the defaults though, right? If we keep original size, someone can zoom out in the composer; if we thumbnail, someone can zoom in in the composer.

@chapoi what do you think?

לייק 1

Are there any plans to hide the button for users who are not logged in and hence cannot quote?

2 לייקים

great catch @moin, will fix.

Yeah sorry … this is kind of what I meant here:

For example :up_arrow: when quoting one of the robots, kind of makes sense to quote it in big.

Also when quoting further up in the topic calling out big makes sense.

This fixes both with an added bonus that if you highlight an image as part of a quote we will also maintain the extension.

how about a thumbnail that when tapped / clicked is linked to the original picture in the original post?

just a thought…. throwing it out there