Links in category banners now show in black

The Category Banner theme component now shows URLs in a different color. These weren’t black before, I believe they had a different color. Is this intended?

3 Likes

Interesting. On a black background, the links show as white. I wonder if it is dependent on the color that is used? (i.e a lighter color = black hyperlink)

The link uses the primary color specified by the color scheme. I think the normal text in the banner uses the foreground color which is chosen in the category settings.

The change for @mentions seems to effect other links as well
https://github.com/discourse/discourse-category-banners/commit/7da1900e78ba47886f44f9ab09036c3dd6b66f56

Right now the banner combined with a light color scheme looks like this:


Maybe it would be better to remove the background of the @mention:

1 Like

This really impairs the readability.

3 Likes

Couple fixes for it here:

https://github.com/discourse/discourse-category-banners/commit/cd2cbb6bfd65f7d07ceb94d9b1bea9454fcf93e0

https://github.com/discourse/discourse-category-banners/commit/e22d73b5dc53e3bc0b3253966291bd4436a21e80

2 Likes

There is still a problem with group mentions and mentioning non-existent users

2 Likes

Group mentions and non-existent user mentions should now be fixed with this commit:

https://github.com/discourse/discourse-category-banners/commit/851f9c42642aee194c8ec5689c8170c42bdb6821

1 Like