Linting consistency

Dev
1

I swear I’ve copied all the lint stuff from discourse-plugin-skeleton to my plugin and when I run

pnpm prettier  --write "assets/**/*.{scss,js,gjs,hbs}"

in my plugin directory, I get something different than when I run

./bin/lint  --fix plugins/discourse-pfaffmanager/assets/**/*.{scss,js,gjs,hbs}

in the discourse core directory.

Predictably, I guess, the latter is the one that matches what happens when github actions run.

What I’d really like is for the Right Thing to happen when I save in VSCode, which, I’m pretty sure, it yet another issue.

1 Like
2

Yeah @cvx / @david

I also noticed this… linting in plugins is all snowflake material, we have branches for old vs new style of linting in CI and require a bunch of setup in the repo.

I think a great goal is to fix it so bin/lint works for plugins and themes as well. We have not implemented that yet, it only works for core and core plugins.