Log more admin actions

[vchuravy (Valentin Churavy)]

I just noted that a few admin/moderator actions are not audited.
As an example Lock/Unlock user to Trust Level isn’t, but probably should be.

[jomaxro (Joshua Rosenfeld)]

While we’re on the subject…

Blocks by the system user don’t have any context:

Delete post has no context (self-deleted in these cases):

Delete user reveals email address:
https://meta.discourse.org/t/privacy-email-of-deleted-users-displayed-in-staff-logs/39324
Also occurs with revoke email.

3 separate logs for same event (spam topic/user):

[codinghorror (Jeff Atwood)]

Adding context should be a priority, @neil can you add to your list.

[neil (Neil Lalonde)]

Yeah we should definitely try to include context whenever we add something in those logs. Added to my list.

[neil (Neil Lalonde)]

I handled all the things mentioned in this topic.

• log lock/unlock trust level
• log activate/deactivate user
• context added for deleted post because author deleted
• stop displaying email addresses of deleted users. The screened emails list will show the emails of spammers/bad people.
• stop displaying email address for revoked email (can be found on user record as usual)

[jomaxro (Joshua Rosenfeld)]

@jomaxro

Blocks by the system user don’t have any context:

Were you able to handle this too?

[neil (Neil Lalonde)]

Yes the context will include something like “blocked by staff” and “too many flags”, from the reason for the block.

[erlend_sh (Erlend Sogge Heggen)]

While we’re at it, I’ll take the liberty of bumping this:

System admin actions should include reason

I’ve heard from multiple customers who were puzzled by how the system user was quietly taking action on certain posts and users. What’s usually happening here is that our friendly anti-spam measures are simply taking out the But to anyone unbeknownst to this, automated deletions look scary because there’s really nothing to indicate that this is intended behaviour. We can do a better job of clueing the user in to what’s happening by briefly explaining why @system took action by putting…

[codinghorror (Jeff Atwood)]

Can you confirm we are good here @neil and @erlend_sh?

[erlend_sh (Erlend Sogge Heggen)]

I’m still seeing some system deletions with empty descriptions, which is quite confusing:

[codinghorror (Jeff Atwood)]

Those look like email staged users to me, so system is perhaps cleaning up old staged users, can you confirm @zogstrip?

[zogstrip]

@codinghorror

can you confirm @zogstrip?

Confirmed and fixed

https://github.com/discourse/discourse/commit/4addc5e3297061d9a0e37b41c98024f50a31b50d