Low Resolution Flickr/500px Onebox

Contribute Bug
1

Howdy all!

Just ran into this on my instance (v1.8.0.beta1 +33) at https://discuss.pixls.us.

Oneboxing of images from image sites like Flickr and 500px are using low-resolution thumbnails:

Flickr image:
Mairi Mid-Air (In the Lane) | At the pre-LGM photowalk in Fi… | Flickr

Imgur

500px image:
500px

Imgur album:
Imgur: The magic of the Internet
Imgur: The magic of the Internet

Imgur image:
Imgur: The magic of the Internet
Imgur: The magic of the Internet

2개의 좋아요
2

I agree. Added to my list :pencil:

5개의 좋아요
3

That should fix it :wink:

https://github.com/discourse/onebox/commit/15fae6cc6f595e6f753afa585a25f53bed6e6782

https://github.com/discourse/onebox/commit/731a93a5fc35fd58d0d42492be19d9a10ddab9e7

5개의 좋아요
4

I’ve noticed some odd scaling problems with an xkcd onebox link on my instance. Testing if it happens here as well (and if so, there’s a weird scaling issue with xkcd onebox embeds! :slight_smile: ).

2개의 좋아요
6

image.jpg1328×744 119 KB

The good news is, on email the ratio is correct.

–Edit–
I think it is fixed in latest master. Just tested it.

7

It looks like the xkcd image dimensions are swapped.
i.e. height is assigned to width and width is assigned to height.

Is the same onebox code used for both flickr and xkcd?

8

This is still a problem for Flickr’s shortened URL’s. Example:

https://flic.kr/p/T3UqgH

Imgur

2개의 좋아요
9

This appears to still be a problem with xkcd links for instance:

(The preview does show the correct aspect).

Here is the rendered result just now:

image.png767×551 63.4 KB

3개의 좋아요
10

It is due to fixed height requirement on onebox, @zogstrip has it on his list.

3개의 좋아요
11

Awesome, thank you very much (both for this and in general. :slight_smile: )!

13

I have fixes for the XKCD and Flickr shortened URLs in the latest builds of Discourse!

6개의 좋아요