최대 이미지 너비 설정이 YouTube 미리보기를 자름

[meiadeleite (ana)]

최근 저희 포럼에서 임베드된 유튜브 비디오들이 모두 비디오 박스 안에 이미지가 반쪽만 보이도록 표시됩니다. 다음과 같은 형태입니다:

이 문제는 최대 이미지 폭 설정(현재 340px으로 설정되어 있음)과 관련이 있는 것 같습니다. 해당 값을 제거하면 문제가 사라지거든요. 이 설정이 비디오에 영향을 줄 거라고는 예상하지 못했는데… 혹시 버그일까요?

[mentalstring (Paulo)]

FWIW, I think the max image width shouldn’t apply for video (even if technically the preview is done with an image thumbnail). As is it it makes videos look a little broken due to the cropped preview.

As opposed to:

From Now On [The Greatest Showman] - Welsh of the West End

One idea would be to have a separate setting for max video width that applies to videos+thumbnails. Another possibility would be to respect the image max width on the thumbnail, but expand the video object on play. These are only suggestions — I don’t know how complex either of these ideas are to implement.

[Falco]

Yes, this site setting indeed affects all images, including the YouTube thumbnails.

Looks like we need to add another exception for youtube on

https://github.com/discourse/discourse/blob/master/app/assets/javascripts/discourse/app/initializers/ensure-max-image-dimensions.js#L25

cc @jordan.vidrine. To repro locally change the setting and refresh the page.

[jordan.vidrine]

This bug has been addressed and a fix has been merged. Thanks for bringing it to our attention

[mentalstring (Paulo)]

This has been fixed on the posts (youtube thumbnail), but it still crops horizontally squeezes the thumbnail preview on the composer when the max image width is low:

[jordan.vidrine]

Thanks for reporting, are you still seeing this issue?

[mentalstring (Paulo)]

I confirm this is still happening on stable. I’m afraid I don’t have a tests-passed instance at hand where I can check this right now.

This is happening when max_image_width=340.

Once posted, the embedded video itself is fine (ie, image width doesn’t apply to the video) and that part is fixed. But while composing the message, the thumbnail preview gets squeezed. Technically an image, but I don’t think the max_image_width should apply here?

[pmusaraj (Penar Musaraj)]

I recently worked on some changes to image sizes in the post stream (and by extension, previews), and I believe this issue is no longer present in tests-passed. I just tested it locally by setting the max_image_width setting to 340 and using a YouTube link in a post, and I cannot reproduce the issue.

So for the stable branch users, the solution is to wait until the next stable release.