Menu Item -> All site Settings - Please point to /admin/site_settings/category/all_results

Just a wee annoyance :grimacing:

It feels wrong that when clicking the Sidebar Navigation menu for…
discourse-All-site-settings-menu-button

…I arrive (filtered) at
/admin/site_settings/category/required

…instead of arriving at
/admin/site_settings/category/all_results

…and then I am sad

…and after some of these sad moments…

…then I become even more sad as I am reminded about how my short term memory is not what it used to be.

It’s such a tiny thing, I know, but freedom from that recurring moment (and saving that :grimacing: extra click) would help me to be more

2 לייקים

That is odd! @hugh Is there a reason for this, or a small oversight?

לייק 1

I think it might remember the last tab that you were on. But that’s not the case.

I wonder if that would be less confusing, as “all” shows only 100 settings, not all of them.

Yeah. Displaying all 4,168 in a single page load clearly would be worse! … discourse/config/site_settings.yml at main · discourse/discourse · GitHub

Not sure if it was intentional or not. It’s easy enough to fix it with a draft PR FEATURE: Link to "All settings" for real in the admin sidebar by martin-brennan · Pull Request #35263 · discourse/discourse · GitHub . But yeah I’d say the main thing (which I will leave to Hugh) is this question:

Also for @denvergeeks , are you aware that you can search for any setting with the Ctrl+/ admin search shortcut?

2 לייקים

Another thought: We removed the “all” from “all site settings” in the German translation because of the limited space in the sidebar. Maybe it makes sense to do this for other languages too.

לייק 1

This feels like an oversight to me, and it should indeed be on the ‘All’ section of the page. An unfortunate side effect of it starting on ‘Required’ is that when you filter the results, it remains on ‘Required’ so there’s a chance you might not see what you were filtering to find.

The PR from @martin here fixes the issue, so I’m happy to go ahead and see that merged: FEATURE: Link to "All settings" for real in the admin sidebar by martin-brennan · Pull Request #35263 · discourse/discourse · GitHub

That’s something to think about, but I would like to keep the ‘All’ in there, at least for now. Because the page can be filtered to show any of the site settings, ‘All’ is still a correct label. I’m happy to reeavluate that with more feedback about it, though.

3 לייקים

Okay this has been merged now!

2 לייקים