Kleinere Bearbeitung am ersten Beitrag erzeugt Revision trotz Schonfrist, wenn Tagging aktiviert ist

isaac · 23. Februar 2026 um 16:50

Dies wird in folgendem Beitrag behandelt:

github.com/discourse/discourse

FIX: Prevent unnecessary revision when editing first post with tagging enabled (#37989)

main ← fix-tag-revisions

opened 04:11PM - 23 Feb 26 UTC

janzenisaac

+49 -14

When editing the first post of a topic, we send `tags: []` via `PUT /t/:id` even… when the topic has no tags. Since `[].present?` is `false`, the existing tag cleanup logic was skipped, leaving a no-op tags key in the changes hash. This caused `PostRevisor#topic_changed?` to return `true` (it checks key presence, not value), bypassing the grace period and creating an empty hidden revision. To fix this I added the condition in `TopicsController#update` to use `has_key?` instead of `present?`, and delete the tags key when both the incoming tags and existing tags are empty. Also added matching normalization in `PostRevisor#revise!`

Thema		Antworten	Aufrufe
Cannot undo a revision if it only includes tag edits Bug pr-welcome	7	176	22. Oktober 2025
Editing tags shouldn't bump the topic's timestamp Feature	11	6129	4. Dezember 2025
Editing post with tags without tagging permission results in tag removal Bug	10	1875	23. November 2015
Adding an invalid tag to a topic creates a whisper post Bug tags , pr-welcome	8	208	5. Dezember 2025
Can't add tags while editing a topic Bug	4	890	18. November 2021

Kleinere Bearbeitung am ersten Beitrag erzeugt Revision trotz Schonfrist, wenn Tagging aktiviert ist

Verwandte Themen