Missing brotli assets

This is fixed per:

https://github.com/discourse/docker_manager/commit/ada600b8522c64a36873512833d3c3d61162b602

https://github.com/discourse/discourse_docker/commit/77edaf675a47729bb693d09b94713a2a98b5d686

https://github.com/discourse/discourse/commit/be59c1559d77cc8028265b8d43477b79b6efccef

:arrow_double_up: (backported to stable and beta)

https://github.com/discourse/discourse/commit/baa7a9836cf547b1ae9eefa51096718706c00602

The root of the problem is that we carried around a strangely named COMPRESS_BROTLI env var to denote we should use brotli compression. This var got eaten by the web upgrader.

I think (not sure) when @david refactored some of the way we do brotli assets our path that used to fallback to non brotli assets stopped doing so.

Anyway… having these two things are a problem:

  1. An oddly named global setting
  2. Brotli even be optional

So now… brotli is unconditionally enabled everywhere including stable and beta.

Keep in mind for about 2-3 years brotli has been “optional default on” and nobody ever really turned it off.

14 Likes