I noticed that the convert button in the theme controls for themes does not have an icon,
whereas it is displayed for theme components.
5 לייקים
Good catch, going to put a pr-welcome on this one.
The change seems to be intentional. @Osama Do you happen to remember why?
לייק 1
I’ve dug into the history here and I believe we decided not to use an icon simply because we couldn’t find/come up with an icon to represent components.
This is a screenshot from when the concept of themes and components was introduced (2018). There’s no icon for the components tab for the same reason.
Given all the recent changes we’ve made around themes/components, I’m not sure if it even makes sense to have the convert button anymore — I don’t think there’s a use case for it these days? I certainly don’t remember the last time I needed to use it.
2 לייקים
I think a simple change we can make here is just to use a consistent icon for the button which I am proposing in this PR:
There should be no need for the button’s icon to convey the kind of conversion that is happening for the theme because that is handled by the confirmation dialog when the button is clicked.
Pinging @hugh and @awesomerobot for a quick review.
4 לייקים
This looks good to me 
2 לייקים
This topic was automatically closed after 3 days. New replies are no longer allowed.