My forum has been updated to Discourse version ed00bce10a9e2ad5f12f6ae6b3a229bb62cf2d2b, which contains discourse/discourse#43495. We still see these unexpected buttons on the “User Needs Approval” review items.
Maybe the report was not clear. The problem is not that context was missing. The problem is that we already resolved the review item by suspending the user via the flag review interface. There is no reason for there to still be this “Yes” button on a resolved review item. It only causes confusion by making it seem like some additional action is required to complete the review, but the only action it offers is for us to approve the user, which wouldn’t make sense as they are spammers. No other type of review item has buttons after being reviewed and these buttons were not previously present on the “User Needs Approval” review items.
Ah I see now, thanks for the additional detail, this required some untangling… I assumed this was something we missed earlier with review queue changes, but it’s a side effect of another change that wasn’t meant to impact the review queue.
The original issue was that with must_approve_users on, users with a review queue item that had already been handled but who were still unapproved couldn’t be approved from their admin page, because approval only worked on pending items. The fix allowed user approval even with already handled queue items. That fixed the admin page, but it also produced the approve button on handled items in the review queue.
So rather than fixing the context, that approve button shouldn’t appear as you said. I’ve got a fix on the way that will hide that in the review queue again:
