Muted categories showing for anonymous users

pfaffman · September 15, 2021, 4:58pm

So here’s the issue.

If mute_all_categories_by_default is set, then it ignores the muted categories list. It’s giving me all categories if mute_all_categories_by_default, but obeys the default_categories_muted if it’s not.

github.com/discourse/discourse

lib/topic_query.rb

main


      
              result.joins(
                "LEFT OUTER JOIN topic_users AS tu ON (topics.id = tu.topic_id AND tu.user_id = #{@user.id.to_i})",
              ).references("tu")
          end
          
          category_id = get_category_id(options[:category])
          @options[:category_id] = category_id
          if category_id
            if ActiveModel::Type::Boolean.new.cast(options[:no_subcategories])
              result = result.where("topics.category_id = ?", category_id)
            else
              result = result.where("topics.category_id IN (?)", Category.subcategory_ids(category_id))
              if !SiteSetting.show_category_definitions_in_topic_lists
                result =
                  result.where(
                    "categories.topic_id IS DISTINCT FROM topics.id OR topics.category_id = ?",
                    category_id,
                  )
              end
            end
            result = result.references(:categories)

This seems like a bug, to ignore the muted categories, or maybe it doesn’t make any sense to have muted categories if all categories are muted by default. But it would seem like if all categories are muted by default and there are no watched categories then it should show nothing?

Topic		Replies	Views
Muted categories appear in Categories page UX	16	2539	November 17, 2021
Muted categories behavior for anon users? Product Support	0	132	May 10, 2024
Mute `default_categories_muted` for anonymous users Feature	2	696	November 20, 2019
Filter view for muted categories Feature	6	1674	July 31, 2020
Muted categories are too atomic Feature	13	5011	June 18, 2014

Muted categories showing for anonymous users

Related topics