Muted categories showing for anonymous users

pfaffman · August 30, 2021, 2:32pm

I have a site with a bunch of muted categories. These categories and topics are hidden when visiting as a logged-in user, but anonymous users see these categories (on /categories) and topics from those appear in /latest.

EDIT: FWIW:

      <meta name="generator" content="Discourse 2.8.0.beta4 - https://github.com/discourse/discourse version b673fee9464e823de3c3423a5f8c45732896b429">

sam · August 31, 2021, 5:39am

@vinothkannans I vaguely recall we dealt with this issue in the past, do you remember?

vinothkannans · August 31, 2021, 6:07am

Yes, we pushed a fix for that. I will check the issue again.

pfaffman · September 4, 2021, 5:06pm

Just checking on this. I upgraded to the current beta6 and the problem persists.

vinothkannans · September 5, 2021, 1:05pm

@pfaffman I’m unable to reproduce this issue both in my development environment and personal site. It is working properly for me.

On /categories page, if a muted category has subcategories which are not muted then it will appear to display the list of sub-categories.

here is the old fix

https://github.com/discourse/discourse/commit/57bbcf4c5db4a99d2e01324ee2f172b741fcc5f9

pfaffman · September 7, 2021, 3:09pm

Thanks for checking. I’m pretty stumped, then.

My best guess is that it’s something with the question/answer plugin, thoug disabling it didn’t change anything. I don’t see how a theme component could change that.

pfaffman · September 15, 2021, 4:58pm

So here’s the issue.

If mute_all_categories_by_default is set, then it ignores the muted categories list. It’s giving me all categories if mute_all_categories_by_default, but obeys the default_categories_muted if it’s not.

github.com/discourse/discourse

lib/topic_query.rb

main


      
              result.joins(
                "LEFT OUTER JOIN topic_users AS tu ON (topics.id = tu.topic_id AND tu.user_id = #{@user.id.to_i})",
              ).references("tu")
          end
          
          category_id = get_category_id(options[:category])
          @options[:category_id] = category_id
          if category_id
            if ActiveModel::Type::Boolean.new.cast(options[:no_subcategories])
              result = result.where("topics.category_id = ?", category_id)
            else
              result = result.where("topics.category_id IN (?)", Category.subcategory_ids(category_id))
              if !SiteSetting.show_category_definitions_in_topic_lists
                result =
                  result.where(
                    "categories.topic_id IS DISTINCT FROM topics.id OR topics.category_id = ?",
                    category_id,
                  )
              end
            end
            result = result.references(:categories)

This seems like a bug, to ignore the muted categories, or maybe it doesn’t make any sense to have muted categories if all categories are muted by default. But it would seem like if all categories are muted by default and there are no watched categories then it should show nothing?

Topic		Replies	Views
Muted categories appear in Categories page UX	16	2539	November 17, 2021
Muted categories behavior for anon users? Product Support	0	132	May 10, 2024
Mute `default_categories_muted` for anonymous users Feature	2	696	November 20, 2019
Filter view for muted categories Feature	6	1674	July 31, 2020
Muted categories are too atomic Feature	13	5011	June 18, 2014

Muted categories showing for anonymous users

AI-generated summary

Related topics