Wingtip
21 בפברואר, 2020, 7:42pm
1
We’re running 2.4.0.beta11 (cf0c6d5761). Topic muting is completely broken for us.
When I mute a topic in a category that is not muted:
It appears to work:
But then when I refresh the page with F5, the mute is gone, and it still shows up in the Latest view.
Is this a known bug? We haven’t changed our configuration recently, although we do update fairly regularly and are on the very latest version as of today.
5 לייקים
j.jaffeux
(Joffrey Jaffeux)
21 בפברואר, 2020, 7:48pm
3
Yes I can repro. It’s very unexpected. It seems to happen only on muted from the timeline, muted from under a topic seems to work, and other actions work. It’s the same component. Digging, will probably have a fix shortly.
6 לייקים
Wingtip
21 בפברואר, 2020, 7:50pm
4
Fantastic! Thanks Joffrey as always.
לייק 1
j.jaffeux
(Joffrey Jaffeux)
21 בפברואר, 2020, 8:16pm
5
Ok, fixed, good catch, thanks!
https://github.com/discourse/discourse/pull/9021
This should fix it and add more tests to prevent future regression on this topic timeline button.
Waiting for tests and will merge it.
11 לייקים
Wingtip
21 בפברואר, 2020, 8:17pm
6
Thanks, appreciate if you could give a heads-up when it’s merged so we can update, had a bunch of users complaining about this.
4 לייקים
j.jaffeux
(Joffrey Jaffeux)
21 בפברואר, 2020, 8:55pm
7
This is merged and in tests-passed.
Let me know how it goes for you, I’m online few more hours and can fix more if needed.
5 לייקים
Wingtip
21 בפברואר, 2020, 9:13pm
8
Confirmed fixed. Thanks again!
6 לייקים