Mijn `goedkeuringsposttelling` werkt niet wanneer ingesteld op 1

AI-generated summary

Richie reported a bug where setting approve post count to 1 caused a new user’s second post to still require approval, despite the expectation that only the first post should. codinghorror suspected an off-by-one error and flagged it for review. eviltrout investigated and confirmed the issue: new topics were not being counted toward the post count threshold. A fix was implemented in this commit, ensuring new topics are now included. Richie later confirmed the fix works across multiple scenarios — new topic + reply, new topic + new topic, and reply + reply — with only the first action requiring approval and subsequent posts publishing immediately. Thanks were extended to eviltrout for the quick resolution.

Hi everyone,

Bit of an odd problem on my Discourse which may be caused by another setting, but I’m not sure.

I’ve set approve post count to be 1

Sure enough, when a new user signs up and posts, it needs approval.

When their post is approved we’re finding that their second post also always needs approval:

With their second post approved they can then make a third post with no further interaction required.

Strange.

If I set the approve post count to be 2, then their third post does NOT need approval.

The issue seems to only be in place if set to 1.

Have I missed another related setting? Is this by design? Am I misunderstanding that design? :thinking:

5 likes

This might be a bug. (off by one strikes again?) We should have a look next week @eviltrout.

4 likes

Let me know if you need any more information or other current settings from my Discourse?

Thanks, I’ll leave it with you :+1:t2:

1 like

A quick look at the logic internally shows that 1 should be an acceptable value. Can you tell us the values of the these related setttings?

  • approve unless trust level
  • approve new topics unless trust level

I’m wondering if you have a trust level setting that a user graduates past around 3 posts.

Thanks for taking a look @eviltrout

Settings as requested:

3 likes

Thanks. I was able to reproduce locally. It seems new topics weren’t counted towards that post count. They are now and it should fix it for you:

https://github.com/discourse/discourse/commit/add3d46bc0ba29b7ced2cda9c540eb9c2e90d96d

9 likes

Fantastic :clap:t2:

I may not get a chance to update my Discourse before Friday but thank you in advance Robin @eviltrout - very grateful :bowing_man:

3 likes

Fix confirmed!

I tried:

  • New topic + reply

  • New topic + new topic

  • Reply + reply

The first action always needs approval, the second action now always goes straight through without an issue.

Thanks again @eviltrout :smiley:

4 likes