MyBB importer exposes deleted posts

After going through a thread with 400+ posts to see why the original thread had 415 posts while the imported one had 417, it appears that the importer doesn’t mark deleted posts in any way.

MyBB soft-deleted posts and they’re no longer visible even to Admins. After importing into Discourse, the deleted posts were visible to all users. This may pose a privacy problem if sensitive data had been exposed in the deleted posts.

5 Likes

Pretty sure that many years later this is still the case:

https://github.com/discourse/discourse/blob/f1cd599966fc55102201161b877c3b25f0c1df5e/script/import_scripts/mybb.rb#L106-L121

Adding a PR welcome in case anyone wants to repair this importer. :arrow_double_up:

4 Likes

This should fix this problem.

2 Likes