- Click a bookmarked item
- Then hit back
- It doesn’t navigate back to where you were in bookmarks, it goes back to the previous bookmarked post/pm/etc that you visited instead.
5개의 좋아요
I can repro this here on Meta.
2개의 좋아요
When you say “click a bookmarked item”, where are you? Can you show a screenshot?
3개의 좋아요
I’m on the bookmarks page: Discourse Meta - The Official Support Forum for Discourse.
Steps I took:
- Open user menu
- Click bookmark icon twice (to navigate to full bookmark activity page)
- Click a topic
- Click back
If I was to do that right now, when clicking back I’d end up here, in this topic, rather than landing on the bookmark activity page as I’d expect.
4개의 좋아요
Click that bookmark, then hit back…you’ll wind up at whatever previous topic/post/pm you visited prior to clicking the “bookmarked item”.
5개의 좋아요
Confirmed, yeah something is not right with our Ember routing here @martin can repro in safe mode.
Can you have a quick look? If it becomes a bit too much of a rabbit hole ping @eviltrout or @j.jaffeux for a hand.
3개의 좋아요
It was fairly straightforward, I have a fix up for review now:
https://github.com/discourse/discourse/pull/12936
The topic-link component (which isn’t used in many places, the bookmark list is one of three) was just missing data-auto-route on the link generated.
7개의 좋아요