simonk
7. August 2026 um 14:49
2
Diese Änderung bricht die Navigation ab, wenn der Benutzer sich bereits auf Discourse befand:
committed 12:03AM - 27 Jun 23 UTC
Why is this change required?
The `/new-topic` route is a special route which … we use to open the
composer by loading a URL. By default, the `new-topic` route is replaced with the
`discovery.latest` route. On a fresh page load, this makes sense since
there is no template for the `new-topic` route to render. However, this
behavior does not make sense if we're transition from another route.
There is no need to replace the current route with the `discovery.latest` when all we want
is to open the composer.
What does this commit do?
This commit fixes the undesirable behaviour described above by aborting
the existing transition to the `new-topic` route if `transition.from` is
present. This indicates that we're navigating from an existing route and
we can just open the composer.
Der Code hat sich seitdem geändert und sieht jetzt so aus:
async beforeModel(transition) {
if (!this.currentUser) {
transition.send("showLogin");
return;
}
const { queryParams: params } = transition.to;
const category = await this.#loadCategoryFromTransition(params);
if (category) {
// Using URL-based transition to avoid bug with dynamic segments and refreshModel query params
// https://github.com/emberjs/ember.js/issues/16992
this.router
.replaceWith(`/c/${category.id}`)
.followRedirects()
.then(() => {
if (this.currentUser.can_create_topic) {
this.#openComposer(params, category);
}
});
Der if (category) {-Block wird vor dem Block ausgeführt, der prüft, ob sich der Benutzer bereits auf Discourse befand, sodass die Navigation fortgesetzt wird. Das erscheint mir in der falschen Reihenfolge zu sein.