The discussion addresses a bug where the ‘sign in’ option is missing from the invitation acceptance page, leaving only the signup form. gassim reports that previously, users could either log in or sign up, but now the login option is absent, causing confusion for existing users. sam acknowledges two issues: the lack of a login link and the absence of live email validation on the invite page, unlike the signup page. martin explains that email validation is not implemented on the invite page, only username validation, and notes that SSO complicates this. sam references a fix by jordan.vidrine that adds a login button at the bottom of the page but not in the header. gassim argues that the login option should be visible in the header for clarity, especially for users already logged out but with existing accounts, as the current form may mislead them into creating a new account. jordan.vidrine explains the design rationale for hiding the login button to avoid confusion for new users, suggesting custom CSS as a workaround for those needing visibility.
Previously, if someone is not logged in and used an invitation link, they are given either of two options:
Currently, the login option is gone, is this on purpose? In other words, if someone is already a member, do they need to login first and then go back to the invitation link to be able to use it?
I hope this is actually a bug and can be fixed soon.
Thank you so much!
Yeah I hear you, there are 2 oddities here we probably want to address:
Vs: Create account page:
In fact the page is so stripped down you have edit URL to find the home page.
I agree we should fix both issues. So the TODO is:
Ensure a login and way to get to home link is included on the accept invite stripped down page.
Fix the issue where we are not doing live email checks, like we do on sign up which leads to confusion.
On Meta I get the same behaviour if I try to sign up with a taken email, though it’s a little janky. It shows this at first:
But if I refocus the input then tab away form it, I get the expected:
Here is the signup email checker on the input:
However we don’t seem to check it on the invitation page, it only checks the username via the UsernameValidation mixing:
So I think we need to add the check on the invite page, however we need to be careful because SSO can be used there as well and that has its own external email validation logic.
@jordan.vidrine gave a shot at fixing this at:
https://github.com/discourse/discourse/pull/19073
Hopefully we will be able to merge it in soon.
Thanks!
Yes, it’d be great if this one can be put back up. The fix you shared by @jordan.vidrine here adds the login to the bottom of the page but not to the header. It is important to have the Login where it usually is because it’s more visible, please.
Thank you!
I definitely understand that perspective, but the reason it is hidden on the invite redemption page is that “Login” in the header could be confusing as the first CTA they see, before they begin the account creation process.
If you want the button to be visible, I’d suggest un-hiding it with custom css in a theme component on your forum.
Okay thanks!
This takes into account the users who are ‘new’ and don’t already have an account, but what about those who already have an account but were not logged in when they used the invitation link. It would be confusing to see a long form that they are ‘requested’ to fill in ‘and create a new account’ when they already have one (without a clear indication that if they already have an account, all they need to do, is to login.)
