OMG! I can finally figure out what theme to blame!

AI-generated summary

The discussion title “OMG! I can finally figure out what theme to blame!” suggests a breakthrough in troubleshooting. pfaffman is relieved to discover that a recent commit by david includes the theme ID in deprecation notices, saving them around an hour of troubleshooting time. david shares that this change automates a task they used to do manually, making the process more efficient. Separately, saquetim pushes a commit to resolve a warning, and pfaffman confirms that the fix is successful.

https://github.com/discourse/discourse/commit/ebb5c1ff4dddb03c3684adc60fb87b0ee95f4f6a

Whoever thought to include the theme ID in the deprecation notice is brilliant! (And it’s amazing how things like that can take so long to become “obvious”.) Maybe it was @david, at least he committed it.

image

(No offense intended to the theme in question…)

This saves me on the order of an hour figuring out where to look. (Perhaps a slight exaggeration.)

So fantastic.

31 Likes

Yup! I must have spent so many hours over the last few years manually digging through backtraces to identify problem theme/plugins… and then it dawned on me that we can have a robot do it!! :robot:

24 Likes

None taken. :wink:

Btw, I’ve pushed a commit replacing this.container by this.register to get rid of the warning. @pfaffman can you try and confirm that it is gone?

8 Likes

Awesome! That did it. I was going to try to submit a PR yesterday but got in a fight with git.

Thanks!

2 Likes