Onebox of github commits overview is just the onebox of the first commit

Hello,

for the link https://github.com/beta-europe/www.beta-europe.org/commits/master, I expected to have a onebox different from a precise commit. This is a bit misleading.

Onebox for the link above:

(edit by @david: screenshot of the old result, for future reference)

https://github.com/beta-europe/www.beta-europe.org/commits/master

4 إعجابات

Agree, we can do better here pr-welcome

3 إعجابات

Links leading to issues and pull requests overview both render whitelistedgeneric onebox:

https://github.com/rails/rails/issues
https://github.com/rails/rails/pulls

Should the same happen when adding a link to commit history as well?

إعجاب واحد (1)

As Maja suggested, links to multiple commits will now be rendered using the whitelistedgeneric onebox

Unfortunately the opengraph data which github provides for these URLs is generic - it will just show the repo name/description. However, I still think this is less confusing than arbitrarily rendering the first commit.

A brand new onebox for these “multi-commit” links would still be pr-welcome, if someone would like to try it.

5 إعجابات