dfabulich
5월 23, 2018, 3:13오전
1
This onebox has a white space in the upper left corner on Chrome, or, on Firefox, it shows a broken image icon.
The document contains a <link> tag like this:
<link href="icon.jpg?hash=daf03254ad467bb13b79bb3b5a637832" rel="icon">
That should resolve to https://www.choiceofgames.com/grand-academy-for-villains/icon.jpg?hash=daf03254ad467bb13b79bb3b5a637832 (which exists) but Discourse is incorrectly attempting to use https://www.choiceofgames.com/icon.jpg?hash=daf03254ad467bb13b79bb3b5a637832 which doesn’t exist and gets a 404 error.
3개의 좋아요
sam
5월 23, 2018, 3:16오전
2
@techAPJ can you sort this out? perhaps if there is no domain just add the originating domain in the onebox lib?
3개의 좋아요
techAPJ
5월 23, 2018, 12:49오후
4
We already do that. The issue here was that the link was page relative url (icon.jpg) vs root relative url (/icon.jpg). We were not distinguishing between these two types. Now fixed via:
https://github.com/discourse/onebox/commit/967a1f753cd3d9b07f15b6abf0c6d5ab7c94925c
Thanks for bringing this in our notice @dfabulich .
7개의 좋아요
