Orientation fix missing in latest stable

RGJ · 2018 年2 月 3 日 08:45

Saturday morning is always a good moment to research weird problems.
I suddenly see things that I’ve overlooked for a long time.

The image orientation fix seems to be missing in the stable branch.

Can you please, please backport it for 1.9.3 ?

Master:

github.com/discourse/discourse

lib/upload_creator.rb

main


      
          def initialize(file, filename, opts = {})
            @file = file
            @filename = (filename || "").gsub(/[^[:print:]]/, "")
            @upload = Upload.new(original_filename: @filename, filesize: 0)
            @opts = opts
            @filesize = @opts[:filesize] if @opts[:external_upload_too_big]
            @opts[:validate] = (
              if opts[:skip_validations].present?

Stable:

github.com/discourse/discourse

lib/upload_creator.rb

stable


      
          def initialize(file, filename, opts = {})
            @file = file
            @filename = (filename || "").gsub(/[^[:print:]]/, "")
            @upload = Upload.new(original_filename: @filename, filesize: 0)
            @opts = opts
            @filesize = @opts[:filesize] if @opts[:external_upload_too_big]
            @opts[:validate] = (

codinghorror · 2018 年2 月 3 日 15:16

Sure @zogstrip can you take a look?

RGJ · 2018 年2 月 4 日 18:31

I did a diff between stable 1.9.0 and tests-passed 2.0 beta1, which should be pretty much the same, and I found three more differences which should not be there.

https://github.com/discourse/discourse/blob/stable/lib/validators/upload_url_validator.rb#L6
https://github.com/discourse/discourse/blob/master/lib/validators/upload_url_validator.rb#L6

https://github.com/discourse/discourse/blame/stable/lib/final_destination.rb#L208-L223
https://github.com/discourse/discourse/blame/v2.0.0.beta1/lib/final_destination.rb#L208-L218

https://github.com/discourse/discourse/blame/stable/app/assets/javascripts/discourse/templates/components/group-membership-button.hbs#L28-L31

RGJ · 2018 年2 月 16 日 17:03

@zogstrip @neil do you have any plans to merge these changes back in to stable ?

zogstrip · 2018 年2 月 16 日 17:06

Yup. Topic isn’t closed and still is assigned Just haven’t got a chance to do it yet.

RGJ · 2018 年5 月 17 日 12:17

Would it be possible to merge the image rotation bugfix back into stable before Discourse 2.0 stable is being released? It’s only a single line in upload_creator.rb that is still causing a lot of headaches.

zogstrip · 2018 年5 月 17 日 12:56

Sorry for the delay. It’s now backported

zogstrip · 2018 年5 月 17 日 16:00

This topic was automatically closed after 3 hours. New replies are no longer allowed.

话题		回复	浏览量
Orientation of images uploaded is wrong Support	19	2156	2018 年1 月 18 日
Is there a way to manually rotate an image Support	29	6655	2020 年12 月 12 日
Mobile image upload turns sideways Support	33	13246	2017 年6 月 23 日
Stable is well... broken Support	8	1136	2018 年4 月 5 日
2.8.2: Minor Patch Release Announcements release-notes	0	448	2022 年3 月 22 日

Orientation fix missing in latest stable

相关话题