Other people's private conversations in 'Suggested messages'

[rizka]

I just flagged a topic here on Meta as “something else”. When you do so, a private conversation between you and moderators is created. Under the discussion, there are ‘Suggested messages’ which I am not part of. I see their titles and participants. However when I click a discussion, I get a connection error so I cannot read them which is good. Under normal messages there are messages from my own messages as it should be.

[tgxworld (Alan Tan)]

Looks like the joins are not unnecessary after all

https://github.com/discourse/discourse/commit/d9714c21c80ab3b8ff68a5520d8086aa8e91588f

[tgxworld (Alan Tan)]

Fixed in

https://github.com/discourse/discourse/commit/1a9762a9c0e830590760a63b9ddb11f17b135921

This was actually due to a combination of PERF: Avoid unnecessary expensive joins if possible. · discourse/discourse@f3fadf4 · GitHub and PERF: Avoid `NOT IN (<subquery>>` which can get really slow. · discourse/discourse@2814819 · GitHub

Added test cases to guard against regression.

Thanks for reporting @rizka