PERF : Il semble y avoir une fuite de mémoire dans frontend-store

saquetim · Janvier 16, 2026, 7:58

PERF: Prevent unbounded growth of store identity map

main ← perf/prevent-evergrowing-cache-store

approved 08:41AM - 16 Jan 26 UTC

Fixes a memory leak reported by @small-lovely-cat in https://meta.discourse.org/…t/perf-there-seems-to-be-a-memory-leakage-in-frontend-store/393510/1 ## Problem The store's identity map holds strong references to every model instance ever fetched during a session. These references are never released, causing memory to grow unbounded as users navigate through the application. Models for topics, posts, categories, and other resources accumulate indefinitely, even after the user has navigated away and the app no longer needs them. ## Why not FIFO/LRU? Traditional cache eviction strategies don't work well for an identity map. If we evict an entry while the app still holds a reference to that model (e.g., it's rendered in a component), the object remains in memory anyway. Worse, the next fetch for that ID creates a *new* instance—consuming more memory and breaking identity semantics where the same ID should always return the same object. ## Solution Introduce `WeakValueMap`, a Map that holds weak references to its values. When a model instance is no longer referenced anywhere else in the application, it becomes eligible for garbage collection, and the identity map entry is automatically cleaned up. **Key implementation details:** - `WeakRef` wraps cached values, allowing GC when unreferenced - `FinalizationRegistry` removes stale map entries after values are collected - Probabilistic sweep (~1% of `get()` calls) as a backup cleanup mechanism This makes the identity map self-regulating—it naturally shrinks when models are no longer in use, while still preserving identity semantics for active models.

Le PR ci-dessus corrigera la fuite de mémoire signalée dans le message initial.

Sujet		Réponses	Vues
`decorateCooked` should be supplied with an `id` option to avoid memory leaks Support	4	927	Juin 14, 2019
Memory is running out and Discourse stops working Bug	74	14697	Février 17, 2015
Leak of stylesheet_cache targets? Development	0	441	Avril 24, 2021
Subscription: fix for blank space on other users' profiles; core: fix loading loop when topic is removed Bug subscriptions	1	144	Décembre 9, 2025
Performance improvements on long topics? Support	29	5650	Juillet 12, 2018

PERF : Il semble y avoir une fuite de mémoire dans frontend-store

Sujets connexes