PG13-Kompatibilitätsproblem 🔥

ted · 18. Oktober 2024 um 04:35

I have a PR up here that should work for PG13 as well.

github.com/discourse/discourse

FIX: Make problem check tracker unique constraint work on PG13

discourse:main ← discourse:fix/problem-check-target-pg13

opened 03:40AM - 18 Oct 24 UTC

Drenmi

+32 -11

### What is this change? In #29169 we added a `NULLS NOT DISTINCT` option to …the unique index on `problem_check_trackers`. This is to enforce uniqueness even when the `target` is `NULL`. (Postgres considers all `NULL`s to be distinct by default.) However, this only works in PG15. In PG13 it does nothing. This commit adds a default dummy string value `__NULL__` to `target`. Since it's a string, PG13 will be able to correctly identify duplicate records. ### Is it safe to run this? Adding a default value will lock the table and can cause issues on large tables, but the `problem_check_trackers` table is constrained by the number of problem check classes, and is in the ballpark of 10-100 rows.

We’re still considering how realistic this case is in the wild, and how much we should potentially invest in working around it.

Thema		Antworten	Aufrufe
Restore fails - could not create unique index Installation	22	3786	6. Juli 2020
"EXCEPTION: psql failed: DETAIL: Key (post_id)=(36946) is duplicated." Installation	8	1170	20. Juni 2022
Restore fails: could not create unique index Installation	10	1197	13. Februar 2022
Problem with restore Discourse from backup (3.4, quite large DB) Support	18	213	14. Januar 2025
Error restoring backup "key is duplicated" Installation	8	1802	31. August 2017

PG13-Kompatibilitätsproblem 🔥

Verwandte Themen