tvavrda
(Tomas Vavrda)
11. Januar 2025 um 15:54
1
iOS 18.2 pinch zooming mostly crashes. Cannot zoom to images but also anything in a topic.
UPDATE: It seems to happen when you pinch zoom and then you “rough” swipe with one finger (e.g. to move all the way down) when zoomed in. Or zoom out. You must zoom into a content. When you zoom e.g. on buttons, it might not crash.
4 „Gefällt mir“
sam
(Sam Saffron)
12. Januar 2025 um 21:38
3
Crashes like this are likely browser bugs, that said I have alerted the team in case they have any ideas.
2 „Gefällt mir“
david
(David Taylor)
13. Januar 2025 um 10:14
5
I haven’t been able to reproduce this on iOS 18.2.1.
Is anyone else seeing the same problem?
1 „Gefällt mir“
tvavrda
(Tomas Vavrda)
13. Januar 2025 um 10:37
6
OK, I upgraded to 18.2.1 and after few tests I cannot reproduce again.
2 „Gefällt mir“
tvavrda
(Tomas Vavrda)
14. Januar 2025 um 11:23
7
It happened again (iOS 18.2.1). If I zoom in and then I zoom out but much more than 1:1, I can reproduce the crash.
4 „Gefällt mir“
david
(David Taylor)
14. Januar 2025 um 20:09
9
Thanks @tvavrda - a few of us on the team have been able to reproduce the same issue, and are looking into it
3 „Gefällt mir“
sam
(Sam Saffron)
14. Januar 2025 um 23:31
12
It is certainly a browser bug, but @pmusaraj just merged a fix that appears to fix it in our testing.
committed 10:56PM - 14 Jan 25 UTC
Not sure why, but it looks like this `z-index: -1` on the composer
causes iOS to… crash super quickly when pinch zooming . This change was
introduced in 07e5f8907e2a8de27c42c2d6f5a02fc153212288 and is not
strictly necessary, let's try removing.
Can you confirm all is working after you update?
3 „Gefällt mir“
tvavrda
(Tomas Vavrda)
15. Januar 2025 um 22:23
13
It works now on the default theme. But I have GitHub - discourse/graceful installed and there it still crashes
1 „Gefällt mir“
sam
(Sam Saffron)
15. Januar 2025 um 23:00
14
@pmusaraj / @awesomerobot I wonder if graceful has some elements with -1 z-index?
1 „Gefällt mir“
tvavrda
(Tomas Vavrda)
15. Januar 2025 um 23:01
15
It does but removing it did not help. Or maybe I did something wrong.
2 „Gefällt mir“
sam
(Sam Saffron)
15. Januar 2025 um 23:01
16
We will have a look will keep the bug open for now.
(I tagged it for clarity on what the bug has evolved to)
3 „Gefällt mir“
pmusaraj
(Penar Musaraj)
16. Januar 2025 um 02:00
17
This should fix it: FIX: Prevent bug with pinch zooming in Safari iOS by pmusaraj · Pull Request #40 · discourse/graceful · GitHub
I’m going to file this upstream tomorrow (or see if somebody else filed it), this very much feels like a recent regression in Safari on iOS, this code has been in the Graceful theme for a long time.
6 „Gefällt mir“
pmusaraj
(Penar Musaraj)
16. Januar 2025 um 15:13
19
The fix above is now merged, looks good here on meta, hope it’s the same on your instance @tvavrda , thanks for the report!
I tried to repro this on a simple codepen so I could report upstream, but I can’t repro. Something else on our app might contribute to the problem, trouble is, not sure how to track down what else is a contributing factor.
3 „Gefällt mir“
tvavrda
(Tomas Vavrda)
16. Januar 2025 um 15:22
21
Seems good so far! I had a customized theme so I just reproduced your modifications and it looks good. I can finally look at images from my phone! Thanks for the support
4 „Gefällt mir“
tvavrda
(Tomas Vavrda)
21. Januar 2025 um 20:43
22
Pinch zooming stopped working whatsoever to me now
1 „Gefällt mir“
pmusaraj
(Penar Musaraj)
21. Januar 2025 um 20:50
23
Yes, confirmed, must be a different regression. Looking into it!
1 „Gefällt mir“
pmusaraj
(Penar Musaraj)
21. Januar 2025 um 20:53
24
@tvavrda are you testing on Safari for iOS? Here on meta, I can pinch zoom in Safari, but I can’t in DiscourseHub (our mobile app).
I am on iOS 18.2.0 (upgrading to 18.2.1 and testing again).
tvavrda
(Tomas Vavrda)
21. Januar 2025 um 20:54
25
You are right. It works in the browser. I use PWA. There it doesn’t.
2 „Gefällt mir“
david
(David Taylor)
21. Januar 2025 um 23:40
28
Sorry about that! I hadn’t specifically tested DiscourseHub/PWA with one of my recent changes. This commit should fix up pinch-zooming there.
5 „Gefällt mir“
tvavrda
(Tomas Vavrda)
21. Januar 2025 um 23:48
29
Seems to work again on PWA. Thanks!
3 „Gefällt mir“