Poll option list items had no layout container, allowing @mentionmention pills to overlap the option marker or checkbox.
This change makes poll options flex rows so marker and content are always laid out side by side.
CSS only, no behavior or markup changes.
Repro:
Create a poll with options that i@mentionsclude @mentions (mention pills).
In the cooked topic view, the option marker/checkbox can overlap the mention pill.
Fix:
Make poll option list items a flex row so the marker/checkbox and the option content
are laid out side by side with consistent spacing.
Hey just wondering when this will probably go to the main branch? Don“t want to patch my core with my own fix to prevent merge conflicts with Updates in future.
I prefer waiting for the commit to be merged with main, but also wonder how the process will be from here and when.
Thanks in advance.
Hmm, it looks to me like the pull request you linked is targeting your own fork rather than the main discourse/discourse repository. Is there a specific reason why you didnāt open the pull request against the main repository instead?
Usually, the team approves and merges pull requests there. I am not sure they usually look at PRs on forks. Maybe @zogstrip didnāt notice that when he reviewed this.
ah, ok. Thought it will lead to the main branch anyways or pop up there to accept the changes. but i“m not very familar with that and would need support here.
Is the actual state a real dead end if i don“t follow some steps or can somone anyways merge this to the main branch?