Problèmes de positionnement avec les locales RTL suite aux mises à jour récentes

Osama · Décembre 15, 2023, 3:45

Salut @inj3ct0r

Ceci a été corrigé via ce commit :

github.com/discourse/discourse

FIX: Position Float Kit elements correctly in RTL mode (#24908)

committed 10:16AM - 15 Dec 23 UTC

OsamaSayegh

+0 -2

Float-kit elements (menus/tooltips) are positioned where they should be by setti…ng an inline `left` property in JavaScript when they're rendered. For some reasons, we also set `left: 0` on float-kit elements here: https://github.com/discourse/discourse/blob/25d9927785b07697132504fca77b8156600966ff/app/assets/stylesheets/common/float-kit/d-menu.scss#L11-L15 This property is overridden by the inline property that the library sets in JavaScript. However, in RTL mode, all of our scss files are flipped where everything left becomes right and vice versa. In this case, the `left: 0` property in the scss file above becomes `right: 0`. This results in a conflict specific to RTL mode where both the `left` and `right` properties are defined on the same absolute-positioned element; the `right` property will always be set to 0 because it comes from the (flipped) scss file above, and the inline `left` property will be set to some px amount determined in JavaScript. The `right` property will take precedence over the inline `left` property due to the page being right-to-left (source: https://developer.mozilla.org/en-US/docs/Web/CSS/right#description) and this causes float-kit elements to incorrectly always stick to the right. This commit removes the `left: 0` property altogether for float-kit elements from our scss files. It's not clear from git history why the property was added, and removing it doesn't seem to cause any issues. Meta topic: https://meta.discourse.org/t/positioning-issues-with-rtl-locales-after-recent-updates/280220?u=osama

Sujet		Réponses	Vues
User card will not open on the mobile Bug	5	859	Novembre 26, 2020
RTL interface has wrong position for some of popup boxes Bug	11	2010	Octobre 25, 2016
UI Layout Broken for RTL Language After Latest Update Bug ux , rtl	3	317	Mai 27, 2025
Layout for RTL users can't be set per user, only at the whole site level UX	10	1536	Octobre 28, 2019
Usercard Redesign Experiment Feature completed , user-card	127	9515	Juillet 18, 2024

Problèmes de positionnement avec les locales RTL suite aux mises à jour récentes

Sujets connexes