Prioritizing full name vs username in the UX

I just added a site setting that allows you to prioritize full names as opposed to usernames in the UI.

When usernames are prioritized cause the site setting prioritize_username_in_ux is enabled you will see:

In card:

On user page:

In post stream:

If you change it so prioritize_username_in_ux is disabled you will see:

In card:

On user page:

In post stream:

I feel an @ symbol may be worth adding per:

This can be done safely via CSS, leaving it off for now.

Quotes inside the UX still pull in username eg:

We may look at making this switch to be fullname based when the setting is set.

22개의 좋아요

Bug report: If full name is blankish, username is offset and not fully bold

1개의 좋아요

eh?

corrected per

https://github.com/discourse/discourse/commit/0e2d918b3b3807041126bc66d3e0d205d42c7820

Still abusable, but we might as well correct that server side by doing a trim on save that is unicode aware.

3개의 좋아요

That is a can-of-worms to implement, same class as improving quotes. I may get to it, but not for this round.

3개의 좋아요

I believe the username should be shown with @ by the default. It’s a lot less confusing.

And the username should always be visible. Don’t make me think.

5개의 좋아요

At symbol too noisy repeated all over the page. In the user card should suffice.

1개의 좋아요

This is working in almost all places, but not in email notifications.

So, in e.g. user card it looks fine.

But in email notifications full name is not prioritized:

(also I think only one of the two names need be hyperlinked, the first I guess)

2개의 좋아요

@techAPJ can you investigate a fix for emails?

3개의 좋아요

Fixed via:

https://github.com/discourse/discourse/commit/f36719c1f5aac7e72e12f298cf9e23a2076ac17b

When prioritize_username_in_ux is enabled:

When prioritize_username_in_ux is disabled:

4개의 좋아요

Further simplified the styling to use same CSS for username and user-name. (notice the bold font-weight for username vs the normal for user-name.)

https://github.com/discourse/discourse/commit/7b92280b97ea483685040c6c5f8c23b3d8c9f0a2

4개의 좋아요

Pushed another fix here for /about page:

https://github.com/discourse/discourse/commit/e58f0adfcc963305fb16d6c796f51ccfcbe58e00

4개의 좋아요

I found a place where this setting doesn’t seem to be taking effect: the list of username matches on search results:

Geminiscp is the username and prioritize username in ux = true.

3개의 좋아요

We just installed the experimental sidebar and chat. Can full names be prioritized in the Personal chat section as well if we disable prioritize_username_in_ux?

1개의 좋아요