Proxy avatar urls broken in quotes with sub folder install

pfaffman · 6월 20, 2017, 5:58오후

On a subfolder install site I noticed that the avatar letters were broken in quotes.

I don’t really know, but I think that Rails.root in line 124 needs to be replaced with Discourse.getURL (which makes me wonder about the other 71 files that refer to Rails.root)

github.com/discourse/discourse

app/controllers/user_avatars_controller.rb

main


      
          if !Discourse.avatar_sizes.include?(size) && Discourse.store.external?
            closest = Discourse.avatar_sizes.to_a.min { |a, b| (size - a).abs <=> (size - b).abs }
            avatar_url =
              UserAvatar.local_avatar_url(
                hostname,
                user.encoded_username(lower: true),
                upload_id,
                closest,
              )
            return redirect_to cdn_path(avatar_url), allow_other_host: true
          end
          
          upload = Upload.find_by(id: upload_id) if user&.user_avatar&.contains_upload?(upload_id)
          upload ||= user.uploaded_avatar if user.uploaded_avatar_id == upload_id
          
          if user.uploaded_avatar && !upload
            avatar_url =
              UserAvatar.local_avatar_url(
                hostname,
                user.encoded_username(lower: true),
                user.uploaded_avatar_id,

codinghorror · 6월 20, 2017, 11:25오후

What do you think @neil?

neil · 6월 21, 2017, 3:04오후

Yeah that’s probably the reason why. Added this to my list.

neil · 6월 23, 2017, 8:11오후

Hmm no, it seems to be this:

github.com/discourse/discourse

lib/pretty_text/shims.js

main


      
          
          if (!replacement) {
            continue;

which is used in here and here.

I pushed a fix. @pfaffman Give it a try please.

pfaffman · 6월 27, 2017, 7:59오후

It works!

Note to others: You’ll need to rebake after you do this upgrade to fix the avatars in existing posts. (I can’t find simple instructions for doing a simple rebake; doing rake posts:rebake_match["quote"] is probably better anyway rake posts:rebake_match["[quote"] might be better still, but it looks funny.)

글		댓글	조회수
Avatar image URLs inside quotes in imported replies are not re-written Migration phpbb	2	1373	7월 30, 2015
Uploads broken with subfolder installation Bug subfolder	6	666	9월 2, 2022
Only showing the default avatar? Support	3	1268	9월 7, 2017
`[quote]`s use incorrect user avatar after changing avatar Bug	5	813	5월 27, 2024
Profile image changing bug Bug	3	1005	5월 27, 2024

Proxy avatar urls broken in quotes with sub folder install

Related topics