Say, hypothetically, after several days of ugly hacking, I’ve made a bunch of elegant changes to mbox.rb . Things like BUG: make topic post be the first message in thread rather than the last FEATURE: replace email addresses in posts with @username UX: made it clearer where the script looks for fi…

In this case all the commits are against one file, so I’d suggest squashing them all into one commit and making a PR with bullet points that explains what changed. It needn’t go through every line but the general gist would be a good thing for historical purposes. Also since it’s an importer and th…

Thanks. That’s music to my ears! That’s what I thought, but I’m still new to Git and the project, and after hacking on this script for a week, I almost know Ruby. I’ll clean it up and submit it Real Soon Now.

On the “git magic” side of things, if you have the same sort of OCD I have and wanted to split out the changes into separate commits, as long as each logical change was in a separate “hunk” (sections of code delimited by lines starting with @@), you can do: Get a second branch with your code on i…

:thumbsup: That’s the kind of waste-of-time-with-computers nonsense I was talking about! Since almost all I know about Ruby I have learned from reading code, my hack-wildly-until-something-good-happens approach will likely land me in this situation again, and perhaps on code that’s not all in one f…

I have a Ph.D in wasting-time-with-computers from manpage University…

I should arguably post this at Stack Exchange, but this community’s practices are those that I’m interested in following and I already started this thread. . . OK, so I spent several hours today trying to do something like the above on 30 minutes of code changes in discourse-setup. I figured out t…

PRs and granularity

Development

mpalmer (Matt Palmer) 7 سبتمبر 2016، 2:08ص 8

Yes, putting separate changes on separate “feature branches” (as they are called) is generally considered to be The Way, with an “integration branch” to merge all your various things together if you want to run a local fork while waiting for mainline to catch up and merge all your PRs.

الموضوع		الردود	مرات العرض
Github onebox does not point to individual commits in PR links Bug	3	1010	22 يونيو 2017
Onebox of github commits overview is just the onebox of the first commit Feature pr-welcome	3	1055	9 أكتوبر 2019
Recommended approach for production discourse using PR (not merged) Product Support	15	386	21 فبراير 2025
Github - There isn’t anything to compare Product Support	4	1663	22 يناير 2022
[PAID] A Github to Discourse content sync (repo file → topic) Marketplace	3	975	22 يونيو 2021

PRs and granularity

الموضوعات ذات الصلة